fix(config): accept 'model' key as alias for 'default' in model config#3603
Merged
Conversation
Users intuitively write model: { model: my-model } instead of
model: { default: my-model } and it silently falls back to the
hardcoded default. Now both spellings work across all three config
consumers: runtime_provider, CLI, and gateway.
Co-authored-by: ygd58 <ygd58@users.noreply.github.com>
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
NousResearch#3603) Users intuitively write model: { model: my-model } instead of model: { default: my-model } and it silently falls back to the hardcoded default. Now both spellings work across all three config consumers: runtime_provider, CLI, and gateway. Co-authored-by: ygd58 <ygd58@users.noreply.github.com>
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
NousResearch#3603) Users intuitively write model: { model: my-model } instead of model: { default: my-model } and it silently falls back to the hardcoded default. Now both spellings work across all three config consumers: runtime_provider, CLI, and gateway. Co-authored-by: ygd58 <ygd58@users.noreply.github.com>
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
NousResearch#3603) Users intuitively write model: { model: my-model } instead of model: { default: my-model } and it silently falls back to the hardcoded default. Now both spellings work across all three config consumers: runtime_provider, CLI, and gateway. Co-authored-by: ygd58 <ygd58@users.noreply.github.com>
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
NousResearch#3603) Users intuitively write model: { model: my-model } instead of model: { default: my-model } and it silently falls back to the hardcoded default. Now both spellings work across all three config consumers: runtime_provider, CLI, and gateway. Co-authored-by: ygd58 <ygd58@users.noreply.github.com>
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
NousResearch#3603) Users intuitively write model: { model: my-model } instead of model: { default: my-model } and it silently falls back to the hardcoded default. Now both spellings work across all three config consumers: runtime_provider, CLI, and gateway. Co-authored-by: ygd58 <ygd58@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #3544 by @ygd58 — extended the fix to cover all three config consumers instead of just one.
Problem
Users intuitively write
model: { model: my-model }instead ofmodel: { default: my-model }in config.yaml. Themodelkey was silently ignored, causing fallback to the hardcoded default model.Fix
The original PR (#3544) only fixed
runtime_provider.py. This salvage applies the alias at all three read sites:hermes_cli/runtime_provider.py—_get_model_config(): normalizesmodel → defaultearlycli.py—HermesCLI.__init__():model_config.get("default") or model_config.get("model")gateway/run.py— both_resolve_model()and hygiene pre-compression: same fallbackAlso updated:
cli-config.yaml.example— comment noting both keys workwebsite/docs/user-guide/configuration.md— tip box about the aliasFixes #3535
Tests