Skip to content

fix: mattermost configuration parsing bugs#3512

Closed
MPavleski wants to merge 1 commit into
NousResearch:mainfrom
MPavleski:bugfix/mattermost_config_parsing
Closed

fix: mattermost configuration parsing bugs#3512
MPavleski wants to merge 1 commit into
NousResearch:mainfrom
MPavleski:bugfix/mattermost_config_parsing

Conversation

@MPavleski

@MPavleski MPavleski commented Mar 28, 2026

Copy link
Copy Markdown

What does this PR do?

Mattermost (and probably Matrix and Dingtalk) configuration parsing was failing with:

Traceback (most recent call last):
  File "/home/green/hermes-agent/gateway/run.py", line 2481, in _handle_message_with_agent
    agent_result = await self._run_agent(
                   ^^^^^^^^^^^^^^^^^^^^^^
  File "/home/green/hermes-agent/gateway/run.py", line 4908, in _run_agent
    enabled_toolsets = sorted(_get_platform_tools(user_config, platform_key))
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/green/hermes-agent/hermes_cli/tools_config.py", line 416, in _get_platform_tools
    default_ts = PLATFORMS[platform]["default_toolset"]

Related Issue

Fixes #3511

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

hermes_cli/skills_config.py
hermes_cli/tools_config.py
toolsets.py

How to Test

  1. Configure Mattermost
  2. Send message to agent
  3. Agent receives message, and works nominally

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform:

@MPavleski MPavleski changed the title Fixing mattermost configuration parsing bugs fix: mattermost configuration parsing bugs Mar 28, 2026
teknium1 added a commit that referenced this pull request Mar 28, 2026
@teknium1
fix: add homeassistant to skills_config + platform consistency tests
de7a8f0 
Follow-up for cherry-picked #3512:
- Add homeassistant to skills_config.py PLATFORMS (was in tools_config
  but missing from skills_config)
- Add 3 consistency tests that verify all platforms in tools_config have
  matching toolset definitions, gateway includes, and skills_config entries
  — prevents this class of bug from recurring
@teknium1 teknium1 mentioned this pull request Mar 28, 2026
Merged
teknium1 added a commit that referenced this pull request Mar 28, 2026
@teknium1
fix: add missing mattermost/matrix/dingtalk toolsets + platform consi…
ba3bbf5 
…stency tests (salvage #3512) (#3583)

* Fixing mattermost configuration parsing bugs

* fix: add homeassistant to skills_config + platform consistency tests

Follow-up for cherry-picked #3512:
- Add homeassistant to skills_config.py PLATFORMS (was in tools_config
  but missing from skills_config)
- Add 3 consistency tests that verify all platforms in tools_config have
  matching toolset definitions, gateway includes, and skills_config entries
  — prevents this class of bug from recurring

---------

Co-authored-by: DaneelV3 <dannel@v3rtical.tech>
@teknium1

teknium1 commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

Merged via #3583 — your commit was cherry-picked onto current main with authorship preserved. Also added homeassistant to skills_config and 3 platform consistency tests to prevent this class of bug from recurring. Thanks for the fix!

@teknium1 teknium1 closed this Mar 28, 2026
@MiroslavV3

MiroslavV3 commented Mar 28, 2026

Copy link
Copy Markdown

Thanks for merging it. Hate to have a fork :)

@miki-10xlab miki-10xlab mentioned this pull request Mar 29, 2026
Closed
14 tasks
@teknium1 teknium1 mentioned this pull request Apr 27, 2026
Closed
1 task
angelburgosrosado pushed a commit to angelburgosrosado/hermes-agent that referenced this pull request Apr 27, 2026
@teknium1
fix: add missing mattermost/matrix/dingtalk toolsets + platform consi…
d77067d 
…stency tests (salvage NousResearch#3512) (NousResearch#3583)

* Fixing mattermost configuration parsing bugs

* fix: add homeassistant to skills_config + platform consistency tests

Follow-up for cherry-picked NousResearch#3512:
- Add homeassistant to skills_config.py PLATFORMS (was in tools_config
  but missing from skills_config)
- Add 3 consistency tests that verify all platforms in tools_config have
  matching toolset definitions, gateway includes, and skills_config entries
  — prevents this class of bug from recurring

---------

Co-authored-by: DaneelV3 <dannel@v3rtical.tech>
02356abc pushed a commit to 02356abc/hermes-agent that referenced this pull request May 14, 2026
@teknium1
fix: add missing mattermost/matrix/dingtalk toolsets + platform consi…
18136d8 
…stency tests (salvage NousResearch#3512) (NousResearch#3583)

* Fixing mattermost configuration parsing bugs

* fix: add homeassistant to skills_config + platform consistency tests

Follow-up for cherry-picked NousResearch#3512:
- Add homeassistant to skills_config.py PLATFORMS (was in tools_config
  but missing from skills_config)
- Add 3 consistency tests that verify all platforms in tools_config have
  matching toolset definitions, gateway includes, and skills_config entries
  — prevents this class of bug from recurring

---------

Co-authored-by: DaneelV3 <dannel@v3rtical.tech>
olympus-terminal pushed a commit to olympus-terminal/hermes-agent that referenced this pull request May 16, 2026
@teknium1
fix: add missing mattermost/matrix/dingtalk toolsets + platform consi…
61c747c 
…stency tests (salvage NousResearch#3512) (NousResearch#3583)

* Fixing mattermost configuration parsing bugs

* fix: add homeassistant to skills_config + platform consistency tests

Follow-up for cherry-picked NousResearch#3512:
- Add homeassistant to skills_config.py PLATFORMS (was in tools_config
  but missing from skills_config)
- Add 3 consistency tests that verify all platforms in tools_config have
  matching toolset definitions, gateway includes, and skills_config entries
  — prevents this class of bug from recurring

---------

Co-authored-by: DaneelV3 <dannel@v3rtical.tech>
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
@teknium1
fix: add missing mattermost/matrix/dingtalk toolsets + platform consi…
a9a3c34 
…stency tests (salvage NousResearch#3512) (NousResearch#3583)

* Fixing mattermost configuration parsing bugs

* fix: add homeassistant to skills_config + platform consistency tests

Follow-up for cherry-picked NousResearch#3512:
- Add homeassistant to skills_config.py PLATFORMS (was in tools_config
  but missing from skills_config)
- Add 3 consistency tests that verify all platforms in tools_config have
  matching toolset definitions, gateway includes, and skills_config entries
  — prevents this class of bug from recurring

---------

Co-authored-by: DaneelV3 <dannel@v3rtical.tech>
Egavasyug pushed a commit to Egavasyug/hermes-agent that referenced this pull request Jun 10, 2026
@teknium1
fix: add missing mattermost/matrix/dingtalk toolsets + platform consi…
479c3c0 
…stency tests (salvage NousResearch#3512) (NousResearch#3583)

* Fixing mattermost configuration parsing bugs

* fix: add homeassistant to skills_config + platform consistency tests

Follow-up for cherry-picked NousResearch#3512:
- Add homeassistant to skills_config.py PLATFORMS (was in tools_config
  but missing from skills_config)
- Add 3 consistency tests that verify all platforms in tools_config have
  matching toolset definitions, gateway includes, and skills_config entries
  — prevents this class of bug from recurring

---------

Co-authored-by: DaneelV3 <dannel@v3rtical.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Mattermost configuration parsing fails

3 participants

@MPavleski @teknium1 @MiroslavV3