fix(gateway): match _quick_key to _generate_session_key for WhatsApp DMs#350
Merged
teknium1 merged 1 commit intoMar 4, 2026
Merged
Conversation
Contributor
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…e_session_key for WhatsApp DMs Authored by Farukest. Fixes NousResearch#349.
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…e_session_key for WhatsApp DMs Authored by Farukest. Fixes NousResearch#349.
3 tasks
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…e_session_key for WhatsApp DMs Authored by Farukest. Fixes NousResearch#349.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_quick_keyused for interrupt lookup and_pending_messagesin_handle_message()omittedchat_idfor all DMs. But_generate_session_key()includeschat_idfor WhatsApp DMs (since PR #75 added multi user session isolation). The running agent was stored under the full key but looked up with the shorter key, so the lookup always missed.The same mismatch existed in
_handle_usage_command().Both sites now use the same three branch logic as
_generate_session_key().Tests
Added
TestWhatsAppDMSessionKeyConsistencytotests/gateway/test_session.pywith 4 tests:_quick_keyincludeschat_idand matches_generate_session_key/usagekey includeschat_idand matcheschat_id(unchanged behavior)chat_id(unchanged behavior)Closes #349