Skip to content

fix(docker): seed s6 gateway state for legacy run cmd#34829

Merged
benbarclay merged 2 commits into
NousResearch:mainfrom
donovan-yohan:fix/issue-34339-s6-gateway-state-migration
Jun 1, 2026
Merged

fix(docker): seed s6 gateway state for legacy run cmd#34829
benbarclay merged 2 commits into
NousResearch:mainfrom
donovan-yohan:fix/issue-34339-s6-gateway-state-migration

Conversation

@donovan-yohan

Copy link
Copy Markdown
Contributor

Summary

  • migrate legacy Docker gateway run container intent into root gateway_state.json when s6 reconciliation finds no prior state
  • start the default s6 gateway slot for that migrated legacy command
  • preserve explicit stopped/non-running state by only seeding when gateway_state.json is absent

Closes #34339

Validation

  • uv run --with pytest pytest tests/hermes_cli/test_container_boot.py -q -o addopts=
  • uv run --with ruff ruff check hermes_cli/container_boot.py tests/hermes_cli/test_container_boot.py && git diff --check
  • uv run --with pytest pytest tests/hermes_cli/test_container_boot.py tests/hermes_cli/test_gateway_s6_dispatch.py tests/docker/test_s6_profile_gateway_integration.py -q -o addopts=

@donovan-yohan donovan-yohan force-pushed the fix/issue-34339-s6-gateway-state-migration branch from 6bdfa2b to bdee7f5 Compare May 29, 2026 19:50
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard area/docker Docker image, Compose, packaging labels May 29, 2026
@benbarclay benbarclay merged commit dcbf62e into NousResearch:main Jun 1, 2026
23 checks passed
JoeKowal pushed a commit to JoeKowal/hermes-agent that referenced this pull request Jun 4, 2026
…4829)

* fix(docker): seed s6 gateway state for legacy run cmd

* fix(docker): honor no-supervise during legacy gateway migration

---------

Co-authored-by: Donovan Yohan <donovan-yohan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docker Docker image, Compose, packaging comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gateway not auto-starting after upgrade from tini-based to s6-overlay image — missing migration for gateway_state.json

3 participants