fix(kanban): tell workers not to use clarify; route to kanban_block instead (#32167)#34413
Merged
Merged
Conversation
Contributor
🔎 Lint report:
|
…nstead (#32167) Kanban workers run headless — no live user is on the other side of `clarify`, so the call times out (~120s default) and the task sits silently in `running` with no signal to the operator that input is needed. Reporter observed a real incident where a worker asked 'promote to production, or check staging first?' via clarify, the call timed out, the agent hallucinated a fallback, and the task sat 'running' for hours. Fix: explicit 'do not call clarify' bullet in two surfaces every kanban worker sees — - `agent/prompt_builder.py` KANBAN_GUIDANCE `## Do NOT` section (auto-injected into every dispatcher-spawned worker run). - `skills/devops/kanban-worker/SKILL.md` `## Do NOT` section (the bundled worker skill). Both point at the right pattern: `kanban_comment` (context) + `kanban_block` (decision needed) — the task surfaces on the board as blocked, the operator sees it, unblocks with their answer in a comment, and the worker respawns with the thread. Co-authored-by: kweiner <17778+kweiner@users.noreply.github.com>
76b5422 to
64dcb8a
Compare
Collaborator
|
Supersedes #32183 — same fix (forbid clarify in kanban workers), salvaged onto current main with the code relocated to pt_input_extras pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Kanban workers run headless — no live user is on the other side of
clarify. The call times out (~120s default) and the task sits silently inrunningwith no signal to the operator that input is needed.Reporter (#32167) observed a real incident: a worker asked 'promote to production, or check staging first?' via clarify, the call timed out, the agent hallucinated a fallback, and the task sat 'running' for hours.
Changes
agent/prompt_builder.py— KANBAN_GUIDANCE## Do NOTsection gets an explicit 'do not call clarify' bullet (auto-injected into every dispatcher-spawned worker).skills/devops/kanban-worker/SKILL.md— same bullet in the bundled worker skill's## Do NOTsection.scripts/release.py— AUTHOR_MAP entry for @kweiner.Both point at the right pattern:
kanban_comment(context) +kanban_block(reason=...)(decision needed). The task surfaces on the board as blocked, the operator sees it, unblocks with their answer in a comment, the worker respawns with the thread.Validation
running, clarify times out at 120s, agent hallucinateskanban_comment+kanban_blockinsteadCloses #32167. Credit @kweiner for the report and the proposed fix locations.
Infographic