fix(kanban): forbid clarify in worker guidance — use kanban_block instead#32183
Open
JezzaHehn wants to merge 1 commit into
Open
fix(kanban): forbid clarify in worker guidance — use kanban_block instead#32183JezzaHehn wants to merge 1 commit into
JezzaHehn wants to merge 1 commit into
Conversation
…tead Workers run headless with no live user. Calling clarify() always times out and leaves the task stranded in 'running'. Add explicit 'Do NOT call clarify' bullets to both KANBAN_GUIDANCE (prompt_builder.py) and the kanban-worker skill. Closes NousResearch#32167
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #32167.
Kanban workers run headless with no live user on the other end. When a worker calls
clarify(), the call always times out (~120s), the task hangs inrunningwith no visible indicator, and no notification reaches the operator.Changes
Two-line fix across two files:
agent/prompt_builder.py— Added a "Do not callclarify" bullet to the## Do NOTsection ofKANBAN_GUIDANCE. Every kanban worker sees this in their system prompt.skills/devops/kanban-worker/SKILL.md— Added the same rule to the skill-level## Do NOTsection for deeper reference.Both entries tell workers to use
kanban_comment+kanban_blockinstead, which is the existing documented pattern for requesting human input.Testing
test_kanban_guidance_prompt_size_bounded— guidance is 3,969 chars, under the 4,096 captest_kanban_guidance_in_worker_prompt— guidance injected for kanban workerstest_kanban_guidance_not_in_normal_prompt— guidance not injected for normal sessions"clarify"appears in the updatedKANBAN_GUIDANCEtextWhy this approach
The issue reporter suggested exactly these two locations. The
kanban_comment+kanban_blockpattern is already documented and tested — workers just need an explicit rule to never reach forclarify.