fix(kanban): add --reason flag to unblock for symmetry with block (#30897)#34411
Merged
Conversation
…0897) `hermes kanban unblock <id> review-required: ...` parsed every trailing word as another task_id (since `task_ids` is `nargs='+'`), then quietly failed on each non-existent id with "cannot unblock review-required: (not blocked/scheduled?)". Reporter saw this as asymmetric with `block <id> <reason...>` which accepts positional reason words. Fix: add a `--reason "..."` flag that, when provided, is appended as a `UNBLOCK: <reason>` comment before the unblock transition. Bulk syntax (`unblock t_a t_b t_c`) is preserved unchanged. Co-authored-by: julio-cloudvisor <211828103+julio-cloudvisor@users.noreply.github.com>
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
invalid-argument-type |
1 |
First entries
hermes_cli/kanban.py:1994: [invalid-argument-type] invalid-argument-type: Argument to function `add_comment` is incorrect: Expected `str`, found `str | None`
✅ Fixed issues: none
Unchanged: 4890 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
r266-tech
added a commit
to r266-tech/hermes-agent
that referenced
this pull request
May 29, 2026
r266-tech
added a commit
to r266-tech/hermes-agent
that referenced
this pull request
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes kanban unblock <id> review-required: ...quietly failed: every trailing word past the task id was parsed as another task_id (sincetask_idsisnargs='+'), then each non-existent id printed "cannot unblock (not blocked/scheduled?)" on stderr with no signal that the reason was being misinterpreted.block <id> <reason...>accepts positional reason words, so the asymmetry was surprising.Changes
hermes_cli/kanban.py: add--reason "..."flag tounblock; when set, appendUNBLOCK: <reason>as a comment before the unblock transition. Bulk syntax (unblock t_a t_b t_c) preserved.scripts/release.py: add AUTHOR_MAP entry for @julio-cloudvisor.Validation
unblock t_x review neededreview,neededas task ids, prints "cannot unblock review (not blocked/scheduled?)"unblock t_x --reason "review needed"UNBLOCK: review neededcommentunblock t_a t_b t_c(bulk)unblock t_a t_b --reason "both green"Closes #30897. Credit @julio-cloudvisor for the report.
Infographic