fix(hermes_time): add missing reset_cache() function#32987
Open
Kailigithub wants to merge 1 commit into
Open
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
reset_cache()function that is referenced in both the module-level comment and theget_timezone()docstring, but was never implemented. This was item 2 in issue #32848.Changes
hermes_time.py: addreset_cache()function that clears the three timezone cache globals (_cached_tz,_cached_tz_name,_cache_resolved) so that the next call toget_timezone()re-resolves from the environment/config.Why
The module comment and
get_timezone()docstring both say:But the function did not exist, so callers who followed this guidance would get a
NameError. Now the documented API is functional.Testing
python3 -m py_compile hermes_time.py— passesruff check hermes_time.py— cleanpython3 -m pytest tests/test_timezone.py -q— 20 passed