fix: address 13 minor bugs, typos, and inconsistencies#32869
Open
skabartem wants to merge 1 commit into
Open
Conversation
- Fix wrong percentage comments in toolset_distributions.py - Add missing reset_cache() in hermes_time.py - Fix stale docstring in memory_tool.py - Fix strategy count in fuzzy_match.py - Use exact matching instead of LIKE in holographic store - Add missing thread_id to _set_interrupt call - Fix corrupted Unicode emoji in batch_runner.py - Fix lowercase any/callable type annotations - Remove #<TBD> placeholder comment - Fix typo in credential_files.py comment Fixes NousResearch#32848
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toolset_distributions.py(image_gen and terminal_tasks distributions)reset_cache()function inhermes_time.py(referenced in docstring but never defined)tools/memory_tool.py(removed non-existentreadaction)tools/fuzzy_match.py(8 -> 9, add Unicode normalized strategy)LOWER(name) = LOWER(?)) instead ofLIKEinplugins/memory/holographic/store.pythread_idargument to_set_interrupt(False)call inrun_agent.pybatch_runner.pyanytype annotations toAnyintoolset_distributions.pyandcli.pycallabletype annotations toCallableinplugins/disk-cleanup/disk_cleanup.pyandagent/conversation_loop.py#<TBD>placeholder comment inrun_agent.py../. ssh/id_rsa->../.ssh/id_rsaintools/credential_files.pyFixes #32848
Test plan
reset_cache()clears timezone cache and nextget_timezone()re-resolves_set_interrupt(False, thread_id)does not raise with the additional argumentany/callabletype annotations