fix(delegate): pass per-task model override and explicit credentials to runtime provider#32555
Open
tcsenpai wants to merge 1 commit into
Open
fix(delegate): pass per-task model override and explicit credentials to runtime provider#32555tcsenpai wants to merge 1 commit into
tcsenpai wants to merge 1 commit into
Conversation
…to runtime provider
Two fixes in delegate_task():
- Use t.get('model') or creds['model'] so per-task model overrides are
respected when delegating batch subagents (previously ignored)
- Forward explicit_api_key and explicit_base_url to resolve_runtime_provider
so custom/named providers resolve credentials correctly
Both bugs cause delegation failures when using non-default providers.
Collaborator
23 tasks
This was referenced Jun 6, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes in
delegate_task()that cause delegation failures with non-default providers:Fix 1: Per-task model override ignored (L2066)
When using
delegate_taskwith batch tasks that specify different models per task, themodelfield was completely ignored — all subagents got the provider default.Fix 2: Custom provider credentials not forwarded (L2432)
_resolve_delegation_credentialsresolvesconfigured_api_keyandconfigured_base_urlfrom config, but never passes them toresolve_runtime_provider. Custom/named providers that need explicit credentials (API key + base URL) fail to resolve correctly.