fix: honor per-task model override in delegate_task#17718
Open
Kailigithub wants to merge 1 commit into
Open
Conversation
Previously the per-task model field was silently ignored, causing all child subagents to always inherit the parent model regardless of per-task specification. Now follows the same fallback pattern used for role and toolsets. Closes NousResearch#17685
498c206 to
48c8b4f
Compare
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
delegate_tasktool was silently ignoring the per-taskmodeloverride field, causing all child subagents to always use the parent's model regardless of per-task specification.Root Cause
In
_build_child_agent()calls withindelegate_task(), themodelparameter always resolved tocreds["model"](the global delegation model), ignoring any per-taskmodelfield. Other per-task fields likeroleandtoolsetscorrectly used thet.get(...) or global_defaultpattern.Fix
Apply the same fallback pattern used for
roleandtoolsets:This allows each task dict in a batch delegation to optionally specify its own model while preserving the default behavior.
Verification
python3 -m py_compile tools/delegate_tool.pypassesCloses #17685