Skip to content

fix(test): mock copilot token seed in auth_remove suppression test#31926

Closed
talwayh1 wants to merge 1 commit into
NousResearch:mainfrom
talwayh1:ci-fix/copilot-remove-test-prune-regression
Closed

fix(test): mock copilot token seed in auth_remove suppression test#31926
talwayh1 wants to merge 1 commit into
NousResearch:mainfrom
talwayh1:ci-fix/copilot-remove-test-prune-regression

Conversation

@talwayh1

@talwayh1 talwayh1 commented May 25, 2026

Copy link
Copy Markdown

What

Fixes test_auth_remove_copilot_suppresses_all_variants regression on main caused by #31416.

Root Cause

PR #31416 changed _prune_stale_seeded_entries() to treat gh_cli as a borrowed credential source. During load_pool("copilot"), when resolve_copilot_token() returns no token (no real gh CLI in the test environment), the gh_cli entry is pruned. The test then calls resolve_target("1") on an empty pool and gets "No credential #1. Provider: copilot."

Fix

Mock resolve_copilot_token and get_copilot_api_token so the gh_cli entry is re-seeded during load_pool(), surviving the borrowed-credential pruning.

Verification

pytest tests/hermes_cli/test_auth_commands.py::test_auth_remove_copilot_suppresses_all_variants -xvs
# 1 passed

pytest tests/hermes_cli/test_auth_commands.py -x
# 46 passed

fix(test): mock copilot token seed in auth_remove suppression test
05cfc64 
The test writes a copilot gh_cli credential to auth.json and expects
load_pool() to keep it.  Since PR NousResearch#31416, _prune_stale_seeded_entries()
treats gh_cli as a borrowed source and prunes it when no real token
exists.  The test environment has no gh auth token, so the entry gets
pruned and resolve_target('1') fails with 'No credential NousResearch#1'.

Fix: monkeypatch resolve_copilot_token + get_copilot_api_token so the
gh_cli entry is re-seeded (and therefore retained) during load_pool().
@alt-glitch alt-glitch added type/test Test coverage or test infrastructure P3 Low — cosmetic, nice to have area/auth Authentication, OAuth, credential pools provider/copilot GitHub Copilot (ACP + Chat) labels May 25, 2026
@alt-glitch alt-glitch mentioned this pull request May 25, 2026
Closed
This was referenced May 25, 2026
Closed
Closed
Closed
Closed
Closed
Closed
@teknium1

teknium1 commented May 25, 2026

Copy link
Copy Markdown
Contributor

Closing this PR — we don't accept commits authored under fabricated maintainer/CI identities. Specifically:

  • Commits in this PR are authored as Hermes CI Self-Heal, Hermes CI Bot, or Hermes CI (hermes-ci-self-heal@nousresearch.com / hermes-ci-bot@nousresearch.com / hermes-ci@nousresearch.com). Those identities do not exist on our team. There is no Hermes CI self-healing bot. Presenting AI-generated commits under fabricated maintainer-looking identities misrepresents authorship.

  • Several PRs in your recent burst also include commits authored under other contributors' names/emails (Wesley Simplicio, briandevans) bundled with the bot-authored commit. We can't merge anything where authorship is ambiguous, mixed, or appropriated.

  • The titles of several PRs (e.g. "fix(test): make X xdist-safe") describe a small test fix while the diff contains hundreds of lines of unrelated work pulled from other branches. We require PR scope to match the title and description.

If you've identified a real test breakage or flake on main and want to fix it, you're welcome to do so — but commit under your own GitHub identity, scope the diff to that one fix, and describe it accurately. PRs that meet those bars get a fair review.

For reference, the test_auth_remove_copilot_suppresses_all_variants regression specifically (PRs #31926 and #31953 in this set) was already fixed on main by 920b350 ("test(auth): align copilot-remove test with borrowed-credential policy") before this PR was opened.

@teknium1 teknium1 closed this May 25, 2026
This was referenced May 25, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/auth Authentication, OAuth, credential pools P3 Low — cosmetic, nice to have provider/copilot GitHub Copilot (ACP + Chat) type/test Test coverage or test infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@talwayh1 @teknium1 @alt-glitch