fix(acp): handle AuthMethod removal in agent-client-protocol 0.9.0#3154
Closed
ygd58 wants to merge 1 commit into
Closed
fix(acp): handle AuthMethod removal in agent-client-protocol 0.9.0#3154ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
Contributor
Author
|
The test failure (test_429_exhausts_all_retries_before_raising) passes locally and is unrelated to this PR's changes. This appears to be a flaky CI test. |
158d3d7 to
10c8443
Compare
Contributor
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3150
Problem
agent-client-protocol 0.9.0 removed AuthMethod from acp.schema. The newer API uses AuthMethodAgent, AuthMethodEnvVar, AuthMethodTerminal instead. Hermes pinned >=0.8.1,<1.0 in pyproject.toml, so 0.9.0 could be installed, causing ImportError on startup.
Fix
Added compat import:
Also added
if provider and AuthMethod is not Noneguard to prevent crash when neither import works.