fix(acp): rename AuthMethod to AuthMethodAgent for agent-client-protocol 0.9.0#3111
Closed
Mibayy wants to merge 1 commit into
Closed
fix(acp): rename AuthMethod to AuthMethodAgent for agent-client-protocol 0.9.0#3111Mibayy wants to merge 1 commit into
Mibayy wants to merge 1 commit into
Conversation
…col 0.9.0 agent-client-protocol 0.9.0 split the generic AuthMethod class into AuthMethodAgent, AuthMethodEnvVar, and AuthMethodTerminal. The server only constructs agent-type auth methods so AuthMethodAgent is the correct replacement. Fixes the CI ImportError: cannot import name 'AuthMethod' from 'acp.schema'
This was referenced Mar 27, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI import error that's been breaking the test suite on main since
agent-client-protocol0.9.0 landed.Root cause
0.9.0splitAuthMethodinto three specific classes:AuthMethodAgent— agent-managed auth (our case)AuthMethodEnvVar— env var injectionAuthMethodTerminal— terminal promptAuthMethodno longer exists, causing:Fix
Two-character rename:
AuthMethod→AuthMethodAgentin the import and the one call site. Signature is identical — sameid,name,descriptionfields.Verified
tests/acp/test_server.py: 31/31 pass.