fix(agent): use atomic_json_write for request debug dumps instead of bare write_text#30857
Merged
Conversation
Contributor
🔎 Lint report:
|
8 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Crash mid-write no longer corrupts the API request debug dump — the file post-mortem analysis most depends on.
Changes
agent/agent_runtime_helpers.py:dump_file.write_text(json.dumps(...))→atomic_json_write(dump_file, dump_payload, default=str)(import was already there, unused)Validation
default=strdefault=strforwarded through**dump_kwargsdefault=stris load-bearing:bodyis a deepcopy ofapi_kwargsand routinely holds datetime / httpx Response / custom objects. Without it the inner try raises TypeError and the whole dump is silently dropped — strictly worse than the partial-write being fixed.E2E verified: real-world payload with datetime + custom class serializes correctly, no leftover temp files.
Salvage of #30602 (@sprmn24). Cherry-picked their commit onto current main, added
default=strto preserve original serialization behavior.Infographic