fix(agent): use atomic_json_write for request debug dumps instead of bare write_text#30602
Closed
sprmn24 wants to merge 1 commit into
Closed
fix(agent): use atomic_json_write for request debug dumps instead of bare write_text#30602sprmn24 wants to merge 1 commit into
sprmn24 wants to merge 1 commit into
Conversation
Contributor
|
Merged via PR #30857 — your commit was cherry-picked onto current main with your authorship preserved (commit 53cb6d3). Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
dump_api_request_debug()inagent/agent_runtime_helpers.pywrites the request debug dump with barewrite_text(). If the process is killed mid-write (OOM, SIGKILL during a bad API call storm), the dump file is left partially written — this is the file most likely to be examined post-mortem, so corruption here hurts diagnosis of the very failures it was meant to capture.atomic_json_writeis already imported fromutilsat the top of the file but unused here.Type of Change
Changes Made
write_text(json.dumps(...))block with a singleatomic_json_write(dump_file, dump_payload)callHow to Test
agent/agent_runtime_helpers.pyaround line 1065atomic_json_writeis now used instead ofwrite_textpython -m pytest tests/ -q— no regressions expectedChecklist
Code
Documentation & Housekeeping