fix(cli): persist --global through model picker#28770
Open
Torch4084 wants to merge 1 commit into
Open
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The interactive
/modelpicker dropped--globalon the Enter-key path, so the selected model changed for the current session but was not written toconfig.yaml.Closes #28034.
Changes
persist_globalflag in_model_picker_state_handle_model_picker_selection()fall back to the stored flag when called from the Enter-key handlerpersist_globalthrough the picker open path in_handle_model_switch()switch_model(..., is_global=True)callTesting
uv run --extra dev pytest tests/hermes_cli/test_model_picker_global_persistence.py -q