Skip to content

fix(cli): persist global model picker selections#28044

Open
YuanHanzhong wants to merge 1 commit into
NousResearch:mainfrom
YuanHanzhong:fix/28034-model-picker-global
Open

fix(cli): persist global model picker selections#28044
YuanHanzhong wants to merge 1 commit into
NousResearch:mainfrom
YuanHanzhong:fix/28034-model-picker-global

Conversation

@YuanHanzhong

Copy link
Copy Markdown
Contributor

Summary

  • preserve the /model --global flag when opening the interactive model picker
  • pass the stored global flag through picker selection so chosen models are saved globally
  • add regression coverage for the picker selection path

Fixes #28034.

Tests

  • uv run --with pytest --with pytest-xdist pytest tests/hermes_cli/test_model_picker_global_flag.py tests/hermes_cli/test_apply_model_switch_result_context.py tests/hermes_cli/test_model_picker_viewport.py -q
  • uv run --with pytest --with pytest-xdist pytest tests/hermes_cli/test_model_switch_custom_providers.py -q
  • git diff --check
  • uv run python -m py_compile cli.py tests/hermes_cli/test_model_picker_global_flag.py

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists labels May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/model --global does not persist when using the visual model picker

2 participants