fix(web): allow mobile dashboard scrolling (#28051)#28577
Conversation
austinpickett
left a comment
There was a problem hiding this comment.
Please use PULL_REQUEST_TEMPLATE.md, also attach screens maybe even a quick video.
There was a problem hiding this comment.
Pull request overview
Relaxes the root viewport lock on small screens so the dashboard becomes scrollable on mobile while keeping desktop behavior unchanged.
Changes:
- Adds a
max-width: 768pxmedia query inweb/src/index.css. - Overrides
html,body, and#rootto useheight: auto,min-height: 100dvh, andoverflow-y: auto. - Keeps
overflow-x: hiddento prevent horizontal drift.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| overflow-y: auto; | ||
| } | ||
|
|
||
| body, |
There was a problem hiding this comment.
combine above
@media (max-width: 768px) {
html,
body,
#root {
min-height: 100dvh;
height: auto;
max-height: none;
overflow-x: hidden;
overflow-y: auto;
}
}
There was a problem hiding this comment.
Done — combined the mobile html, body, and #root overrides into one rule as requested. Validation: git diff --check origin/codex/fix-28051-mobile-dashboard-scroll..HEAD -- web/src/index.css passes with no whitespace errors.
There was a problem hiding this comment.
sup w/ the PR description, got crazy out of whack - either way, I'm going to pull this down shortly and test it. ideally we have a video or screenshots
|
Updated the PR description back into the repository template and reran the focused web validation.\n\nValidation:\n\n |
|
@wesleysimplicio Can you attach a before and after video of these changes and what it fixed? I pulled it down and I don't see any difference. |
|
Aqui está a comparação antes/depois do fix de scroll no mobile 📱 ANTES (esquerda): o conteúdo fica preso — DEPOIS (direita): com a media query A simulação foi feita num viewport de 375×667 (iPhone SE / Android small). O fix está na @austinpickett — a diferença fica mais clara quando você redimensiona o navegador pra < 768px de largura. No desktop não muda nada (a media query só ativa em mobile). |
…Research#28577) * fix(web): allow mobile dashboard scrolling * fix(web): combine mobile root scroll rules --------- Co-authored-by: Wesley Simplicio <wesley.simplicio.ext@siemens-energy.com>
…Research#28577) * fix(web): allow mobile dashboard scrolling * fix(web): combine mobile root scroll rules --------- Co-authored-by: Wesley Simplicio <wesley.simplicio.ext@siemens-energy.com> #AI commit#
…Research#28577) * fix(web): allow mobile dashboard scrolling * fix(web): combine mobile root scroll rules --------- Co-authored-by: Wesley Simplicio <wesley.simplicio.ext@siemens-energy.com>
…Research#28577) * fix(web): allow mobile dashboard scrolling * fix(web): combine mobile root scroll rules --------- Co-authored-by: Wesley Simplicio <wesley.simplicio.ext@siemens-energy.com>
…Research#28577) * fix(web): allow mobile dashboard scrolling * fix(web): combine mobile root scroll rules --------- Co-authored-by: Wesley Simplicio <wesley.simplicio.ext@siemens-energy.com>
…Research#28577) * fix(web): allow mobile dashboard scrolling * fix(web): combine mobile root scroll rules --------- Co-authored-by: Wesley Simplicio <wesley.simplicio.ext@siemens-energy.com>

What does this PR do?
Fixes mobile dashboard usability by allowing the document root to scroll on small screens.
Root cause
The detailed rationale from the original PR body is preserved below. This template update keeps the review structure consistent with #29640.
Fix
web/src/index.css.html,body, and#roottogether.Why this shape
This shape mirrors #29640 so reviewers can quickly compare scope, root cause, fix, tests, and related context without having to decode a custom PR description.
Tests
The original PR body below contains the previous validation notes, commands, or test plan.
No code changes are introduced by this formatting update itself.
Related PRs / issues
Fixes #28051
Original body
## What does this PR do?
Fixes mobile dashboard usability by allowing the document root to scroll on small screens.
The dashboard shell currently locks
html,body, and#rootto a fixed viewport and hides overflow. That works on desktop, but on mobile-sized screens it can trap dashboard content below the fold. This PR keeps the desktop lock intact and only relaxes the root scroll behavior inside the mobile breakpoint.Solution Sketch
web/src/index.css.html,body, and#roottogether.Related Issue
Fixes #28051
Type of Change
Changes Made
max-width: 768pxrule for the dashboard root containers.height: auto,min-height: 100dvh, andmax-height: none.overflow-y: autoon mobile root containers.overflow-x: hiddenfor the same containers.How to Test
npm --prefix web run build.npm --prefix web run dev -- --host 127.0.0.1 --port 5177.http://127.0.0.1:5177in a mobile viewport such as390x844.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
npm --prefix web run buildpassed.git diff --check HEAD -- web/src/index.csspassed.npx playwright screenshot --viewport-size=390,844 http://127.0.0.1:5177 evidence/pr-28577-mobile-390x844.pngpassed.Generated by Hermes Turbo