feat(telegram): add ignore_root_dm config to drop messages without thread_id#28536
Merged
Conversation
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-reference |
1 |
First entries
gateway/platforms/telegram.py:439: [unresolved-reference] unresolved-reference: Name `Set` used when not defined: Did you mean `set`?
✅ Fixed issues: none
Unchanged: 4700 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
6 tasks
ai-hana-ai
added a commit
to ai-hana-ai/hermes-agent
that referenced
this pull request
May 22, 2026
Ignore root DM is now in upstream (PR NousResearch#28536 merged via commit b6116e0). Re-apply telegramify-markdown patch after rebase to origin/main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #23928 (@ai-hana-ai). When
dm_topicsare configured, root DM messages without amessage_thread_idcause split sessions and user confusion. Newtelegram.ignore_root_dmconfig drops these messages silently so all conversation flows through named topic threads.Conflict resolution: combined with #28492's allowlist enforcement and #28503's allowed_topics gate. All gates run in sequence: auth → allowed_topics → ignore_root_dm → ignored_threads.
Authorship preserved across 2 commits via cherry-pick. 68/68 topic + group-gating tests passing.