feat(bg-review): add bundled/pinned skill protection to review prompts (#27644)#27992
Closed
zccyman wants to merge 1 commit into
Closed
feat(bg-review): add bundled/pinned skill protection to review prompts (#27644)#27992zccyman wants to merge 1 commit into
zccyman wants to merge 1 commit into
Conversation
…prompts (NousResearch#27644) The background review prompts (_SKILL_REVIEW_PROMPT and _COMBINED_REVIEW_PROMPT) now include explicit protection rules for bundled, hub-installed, and pinned skills — aligning with the curator's existing policy at curator.py L345/350. Before this change, bg-review could freely rewrite bundled skills like 'hermes-agent' or pinned skills, while the 7-day curator explicitly skips them. The review agent now sees: • Bundled skills (shipped with Hermes) • Hub-installed skills (installed via hermes skills install) • Pinned skills (marked via hermes curator pin) If only protected skills need updating, the review says 'Nothing to save.' and stops. Fixes NousResearch#27644
|
BoardJames triage: I do not see a branch-local failure in the background-review prompt change. All non-test checks are green (lint/nix/e2e/builds/attribution/history/supply-chain), and the only blocker is the full |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two writer systems govern the same skill files with inconsistent rules:
Users discovering pin via
hermes curator pinreasonably expect protection from automated edits — butbg-reviewignored it.Changes
_SKILL_REVIEW_PROMPTand_COMBINED_REVIEW_PROMPTinagent/background_review.pyhermes skills install), and pinned (viahermes curator pin)curator.pyL345/350Testing
test_background_review.pytests pass (zero regression)Fixes #27644