Skip to content

[Feature]: Align bg-review's bundled/pinned skill handling with the curator #27644

@abisai2

Description

@abisai2

Problem or Use Case

Two writer systems govern the same skill files with inconsistent rules:

Writer Filters bundled? Filters pinned?
7-day curator ✓ Yes (agent/curator.py:350: "DO NOT touch bundled or hub-installed skills") ✓ Yes (curator.py:272, 350)
bg-review (per-session) ✗ No ✗ No

Same target files, two policies. Today this means bundled skills like hermes-agent are protected from the 7-day curator but get freely rewritten by bg-review on every qualifying session. Users discovering pin via hermes curator pin reasonably expect protection from automated edits — but bg-review ignores it.

Proposed Solution

Add a bundled/pinned filter to spawn_background_review_thread (agent/background_review.py) or at the call site in agent/conversation_loop.py:3981-3989. Default to the same allow/deny rules as curator.py. Add a config knob (skills.bg_review_includes_bundled: false) for users who want the old behavior.

Alternatives Considered

  • Document the asymmetry in user-guide/features/skills.md and update hermes curator pin --help to clarify that pin does not cover bg-review. Cheaper but leaves the surprising behavior in place.
  • Add bg-review-specific markers (per the companion issue on per-skill opt-out flags) — solves part of the problem but does not restore consistency between the two writer systems.

Feature Type: Configuration option
Scope: Medium

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Low — cosmetic, nice to havecomp/agentCore agent loop, run_agent.py, prompt buildertool/skillsSkills system (list, view, manage)type/featureNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions