fix(send_message): add WeCom native MEDIA attachment delivery (#27947)#27967
Open
zccyman wants to merge 1 commit into
Open
fix(send_message): add WeCom native MEDIA attachment delivery (#27947)#27967zccyman wants to merge 1 commit into
zccyman wants to merge 1 commit into
Conversation
…search#27947) WeCom adapter already has _send_media_source / _upload_media_bytes / _send_media_message for outbound file delivery, but send_message_tool.py never routed MEDIA files through it — the tool fell through to the "non-media platform" path and silently dropped attachments. Add WeCom to the media-platform routing (same pattern as Weixin) and extend _send_wecom() with a media_files parameter that uploads each file via adapter._send_media_source before sending the text caption. Fixes NousResearch#27947
|
BoardJames triage: this looks shared/systemic rather than branch-local. The PR-specific checks (lint/nix/e2e/builds/attribution/history) are green where completed; the remaining blocker is the main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WeCom adapter already has
_send_media_source/_upload_media_bytes/_send_media_messagefor outbound file delivery, butsend_message_tool.pynever routed MEDIA files through it — the tool fell through to the "non-media platform" path and silently dropped attachments with a warning.Changes
_send_to_platform()(same pattern as Weixin/Feishu/Signal/Yuanbao)_send_wecom()withmedia_filesparameter that uploads each file viaadapter._send_media_sourcebefore sending text captionwecomTesting
tests/tools/test_send_wecom_media.pycovering:test_send_message_tool.pytests pass (zero regression)Fixes #27947