Summary

Six days after #23937 (608 fixes) the codebase had accumulated 241 new PLR6201 violations. Same mechanical x in (...) → x in {...} fix, same zero-risk profile: set lookup is O(1) vs O(n) for tuple and the two are semantically equivalent for hashable scalar membership tests.

This is the resweep cadence noted in tracker #23972 — Phase 1 mechanical auto-fixes need periodic re-runs as the codebase grows.

241 instances fixed via ruff check --select PLR6201 --fix --unsafe-fixes, zero remaining.

What changed

• 119 files, +244/-244 — every change is a one-line (...) → {...} swap on the right side of an in / not in comparison
• Sampled the diff for risky patterns (unhashable values, dict-key semantics, ordering dependencies) — every changed value is a hashable scalar: strings, ints, None, enum members, signal.SIGTERM constants, computed .lower() results

Examples from the diff:

-        if self._state in ("running", "starting"):
+        if self._state in {"running", "starting"}:

-        if msg.type not in (discord.MessageType.default, discord.MessageType.reply):
+        if msg.type not in {discord.MessageType.default, discord.MessageType.reply}:

-    _allow_all = os.getenv("GATEWAY_ALLOW_ALL_USERS", "").lower() in ("true", "1", "yes")
+    _allow_all = os.getenv("GATEWAY_ALLOW_ALL_USERS", "").lower() in {"true", "1", "yes"}

Test plan

• ✅ ruff check clean after the sweep (0 PLR6201 remaining)
• ✅ Compile checks pass on the largest touched files (cli.py, run_agent.py, gateway/run.py, gateway/platforms/discord.py, model_tools.py)
• ✅ Broad subset run on tests/gateway/ tests/hermes_cli/ tests/agent/ tests/tools/: 18,187 passed, 59 pre-existing failures
• ✅ Empirically verified against origin/main with the same test shape — identical 59 failure count, identical category. All 59 are xdist test-order flakes unrelated to this change (they pass when re-run in isolation; same set passes/fails on baseline). Apples-to-apples diff: 2 different transcription tests flaked on the PR branch while 2 different approval/hangup tests flaked on baseline — net zero.

Follows

Same template as #23937 (tracker: #23972).