Skip to content

fix(model-switch): probe /models for custom providers without api_key#27042

Closed
lemassykoi wants to merge 1 commit into
NousResearch:mainfrom
lemassykoi:fix/telegram-model-picker-custom-providers
Closed

fix(model-switch): probe /models for custom providers without api_key#27042
lemassykoi wants to merge 1 commit into
NousResearch:mainfrom
lemassykoi:fix/telegram-model-picker-custom-providers

Conversation

@lemassykoi

Copy link
Copy Markdown
Contributor

Summary

The Telegram/Discord model picker skipped live model discovery for custom providers (llama.cpp, Ollama) unless an api_key was configured. Local providers typically don't require authentication on the /models endpoint.

The CLI's _model_flow_named_custom always probes /models, so this brings the gateway picker into parity.

Change

File: hermes_cli/model_switch.py

-            if api_url and api_key:
+            if api_url:

Testing

  • Verified locally: selecting llama.cpp in Telegram now shows the full list of available models from the /models endpoint instead of only the static model field.

The Telegram/Discord model picker skipped live model discovery for
custom providers (llama.cpp, Ollama) unless an api_key was configured.
Local providers typically don't require auth on the /models endpoint.

The CLI always probes /models, so this brings the gateway picker into
parity.

Change: `if api_url and api_key:` -> `if api_url:`
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery labels May 16, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Related to #20582 (open issue), #19072 (closed fix), #20760 (closed dupe of #19072). The merged #22842 addressed credential pooling for custom endpoint probes but may not have covered the no-api_key case for local providers.

teknium1 added a commit that referenced this pull request May 17, 2026
…tors

Adds release-note attribution mappings for 9 contributors from group 3:
- @darvsum (PR #26766)
- @hueilau (PR #26498)
- @Timur00Kh (PR #27114)
- @Grogger (PR #27061)
- @lemassykoi (PR #27042)
- @draplater (PR #26707)
- @pr7426 (PR #27048)
- @therahul-yo (PR #26215)
- @flamiinngo (PR #27205)

#27154 dropped from this batch — already landed on main as 4e9cedc.
@teknium1

Copy link
Copy Markdown
Contributor

Merged via PR #27302 — your commit was cherry-picked onto current main as part of a batch salvage of low-risk new-contributor PRs. Authorship preserved (fix(model-switch): probe /models for custom providers without api_key). Thanks for the contribution.

@teknium1 teknium1 closed this May 17, 2026
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants