fix(doctor): SSH connectivity check ignores TERMINAL_SSH_USER / PORT / KEY#26851
Closed
Carry00 wants to merge 1 commit into
Closed
fix(doctor): SSH connectivity check ignores TERMINAL_SSH_USER / PORT / KEY#26851Carry00 wants to merge 1 commit into
Carry00 wants to merge 1 commit into
Conversation
…TERMINAL_SSH_KEY The SSH connectivity check in `run_doctor` only passed the host to ssh, using the current OS user and default port 22. When the target requires a different user (TERMINAL_SSH_USER), non-standard port (TERMINAL_SSH_PORT), or a specific identity file (TERMINAL_SSH_KEY), the check always failed with "Permission denied" — even though the agent itself connects fine. Fix: read all four TERMINAL_SSH_* env vars and build the ssh command with -p, -i, and user@host as appropriate, matching how the terminal tool actually establishes the connection.
teknium1
added a commit
that referenced
this pull request
May 17, 2026
…tors Adds release-note attribution mappings for the contributors from group 5: - @haran2001 (PR #27070, #27068) - @ms-alan (PR #26443) - @godlin-gh (PR #26118) - @wesleysimplicio (PR #25777, ext-email form) - @Carry00 (PR #26851) - @alaamohanad169-ship-it (PR #26036) - @hawknewton (PR #26294) (YanzhongSu PR #25879 and flamiinngo PR #27231 already mapped.)
Contributor
|
Merged via PR #27382 — your commit was cherry-picked onto current |
1 task
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…tors Adds release-note attribution mappings for the contributors from group 5: - @haran2001 (PR NousResearch#27070, NousResearch#27068) - @ms-alan (PR NousResearch#26443) - @godlin-gh (PR NousResearch#26118) - @wesleysimplicio (PR NousResearch#25777, ext-email form) - @Carry00 (PR NousResearch#26851) - @alaamohanad169-ship-it (PR NousResearch#26036) - @hawknewton (PR NousResearch#26294) (YanzhongSu PR NousResearch#25879 and flamiinngo PR NousResearch#27231 already mapped.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When
TERMINAL_ENV=sshis set,hermes doctortests SSH connectivity with:This ignores
TERMINAL_SSH_USER,TERMINAL_SSH_PORT, andTERMINAL_SSH_KEY, so the check connects as the current OS user on port 22 with no specific identity file. If the remote requires a different user or key (the common case), the check always fails withPermission denied— even though the agent itself connects successfully.Root cause
doctor.pyline 1053 only readsTERMINAL_SSH_HOSTand passes it directly tossh, discarding the other threeTERMINAL_SSH_*env vars that the terminal tool itself uses.Fix
Build the
sshcommand using all four env vars —user@host,-p PORT, and-i KEY— to match the connection parameters the agent actually uses.Test
Before the fix — with
TERMINAL_SSH_USER=carryconfigured:After the fix:
🤖 Generated with Claude Code