fix(acp): emit native plan updates for todo tool (salvage #26393)#26583
Merged
Conversation
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-import |
1 |
First entries
acp_adapter/events.py:17: [unresolved-import] unresolved-import: Cannot resolve imported module `acp.schema`
✅ Fixed issues: none
Unchanged: 4331 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
45041b6 to
5e5269b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of #26393 from @HenkDz onto current main.
Summary
ACP adapter emits
sessionUpdate: planevents when thetodotool completes, so Zed renders Hermes' todo list in its native task/plan panel instead of only as a generic tool-call transcript block.Changes
acp_adapter/events.py— new_build_plan_update_from_todo_result()parses todo JSON, maps statuses, emitsAgentPlanUpdateafter normal tool-completion updateacp_adapter/server.py— replays native plan updates when loading persisted sessionstests/acp/test_events.py+tests/acp/test_server.py— 4 new tests (live emission, trailing-hint JSON, empty-list clear, load-session replay)Notes
cancelledtodos are preserved ascompletedwith a[cancelled]content prefixValidation
scripts/run_tests.sh tests/acp/test_events.py tests/acp/test_server.py -q→ 83 passed in 1.91sCloses #26393.