Skip to content

fix(acp): emit native plan updates for todo#26393

Closed
HenkDz wants to merge 2 commits into
NousResearch:mainfrom
HenkDz:fix/acp-todo-plan-updates
Closed

fix(acp): emit native plan updates for todo#26393
HenkDz wants to merge 2 commits into
NousResearch:mainfrom
HenkDz:fix/acp-todo-plan-updates

Conversation

@HenkDz

@HenkDz HenkDz commented May 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Translate Hermes todo tool results into ACP native sessionUpdate: plan updates
  • Keep the normal tool completion transcript while adding first-class Zed plan rendering
  • Preserve cancelled todos as completed entries prefixed with [cancelled], since ACP plan status only supports pending/in_progress/completed

Test Plan

  • scripts/run_tests.sh tests/acp/test_events.py::TestStepCallback::test_todo_completion_emits_native_plan_update -q
  • scripts/run_tests.sh tests/acp/test_events.py -q

Notes

  • Clean branch from current upstream/main
  • Scope intentionally limited to ACP event emission and focused tests

@HenkDz

HenkDz commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

CI note: the red e2e job appears unrelated to this ACP-only change. The same Discord adapter failures are already present on current main run 25921974281:

  • tests/e2e/test_discord_adapter.py::TestMentionStrippedCommandDispatch::test_mention_then_command
  • tests/e2e/test_discord_adapter.py::TestMentionStrippedCommandDispatch::test_nickname_mention_then_command
  • tests/e2e/test_discord_adapter.py::TestMentionStrippedCommandDispatch::test_text_before_command_not_detected
  • tests/e2e/test_discord_adapter.py::TestAutoThreadingPreservesCommand::test_command_detected_after_auto_thread

This PR only touches:

  • acp_adapter/events.py
  • tests/acp/test_events.py

Local focused verification passed with:

  • scripts/run_tests.sh tests/acp/test_events.py::TestStepCallback::test_todo_completion_emits_native_plan_update -q
  • scripts/run_tests.sh tests/acp/test_events.py -q

@daimon-nous daimon-nous Bot added type/feature New feature or request P3 Low — cosmetic, nice to have comp/acp Agent Communication Protocol adapter labels May 15, 2026
@teknium1 teknium1 mentioned this pull request May 15, 2026
Merged
@kshitijk4poor kshitijk4poor mentioned this pull request May 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/acp Agent Communication Protocol adapter P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HenkDz