fix(session): clear compressor summary and turn counter on /clear and /new#2640
Closed
dusterbloom wants to merge 1 commit into
Closed
fix(session): clear compressor summary and turn counter on /clear and /new#2640dusterbloom wants to merge 1 commit into
dusterbloom wants to merge 1 commit into
Conversation
… /new reset_session_state() was missing two fields added after it was written: - _previous_summary on the ContextCompressor (added Mar 21 by Teknium) leaked old session compression into new sessions - _user_turn_count (added Feb 22) kept accumulating across sessions, affecting memory flush timing Both are now zeroed on reset. Fixes NousResearch#2635
teknium1
added a commit
that referenced
this pull request
Mar 26, 2026
… /new reset_session_state() was missing two fields added after it was written: - _user_turn_count: kept accumulating across sessions, affecting flush_min_turns guard behavior - context_compressor._previous_summary: old session's compression summary leaked into new session's iterative compression Cherry-picked from PR #2640 by dusterbloom. Closes #2635.
Contributor
|
Merged via PR #3102. Cherry-picked with tests. Thanks @dusterbloom! |
teknium1
added a commit
that referenced
this pull request
Mar 26, 2026
… /new (#3102) reset_session_state() was missing two fields added after it was written: - _user_turn_count: kept accumulating across sessions, affecting flush_min_turns guard behavior - context_compressor._previous_summary: old session's compression summary leaked into new session's iterative compression Cherry-picked from PR #2640 by dusterbloom. Closes #2635.
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
… /new (NousResearch#3102) reset_session_state() was missing two fields added after it was written: - _user_turn_count: kept accumulating across sessions, affecting flush_min_turns guard behavior - context_compressor._previous_summary: old session's compression summary leaked into new session's iterative compression Cherry-picked from PR NousResearch#2640 by dusterbloom. Closes NousResearch#2635.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
… /new (NousResearch#3102) reset_session_state() was missing two fields added after it was written: - _user_turn_count: kept accumulating across sessions, affecting flush_min_turns guard behavior - context_compressor._previous_summary: old session's compression summary leaked into new session's iterative compression Cherry-picked from PR NousResearch#2640 by dusterbloom. Closes NousResearch#2635.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
… /new (NousResearch#3102) reset_session_state() was missing two fields added after it was written: - _user_turn_count: kept accumulating across sessions, affecting flush_min_turns guard behavior - context_compressor._previous_summary: old session's compression summary leaked into new session's iterative compression Cherry-picked from PR NousResearch#2640 by dusterbloom. Closes NousResearch#2635.
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
… /new (NousResearch#3102) reset_session_state() was missing two fields added after it was written: - _user_turn_count: kept accumulating across sessions, affecting flush_min_turns guard behavior - context_compressor._previous_summary: old session's compression summary leaked into new session's iterative compression Cherry-picked from PR NousResearch#2640 by dusterbloom. Closes NousResearch#2635.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
… /new (NousResearch#3102) reset_session_state() was missing two fields added after it was written: - _user_turn_count: kept accumulating across sessions, affecting flush_min_turns guard behavior - context_compressor._previous_summary: old session's compression summary leaked into new session's iterative compression Cherry-picked from PR NousResearch#2640 by dusterbloom. Closes NousResearch#2635.
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
… /new (NousResearch#3102) reset_session_state() was missing two fields added after it was written: - _user_turn_count: kept accumulating across sessions, affecting flush_min_turns guard behavior - context_compressor._previous_summary: old session's compression summary leaked into new session's iterative compression Cherry-picked from PR NousResearch#2640 by dusterbloom. Closes NousResearch#2635.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/clearand/newcallreset_session_state()which resets token counters and the todo store, but misses two fields that were added after the reset function was written:ContextCompressor._previous_summary(added Mar 21 in e75f584) — old session's compression summary leaks into new session's iterative compression_user_turn_count(added Feb 22 in 3c6750f) — keeps accumulating across sessions, affectingflush_min_turnsguard behaviorBoth are simple oversights — the features postdate
reset_session_state().Changes
run_agent.py: Addedself._user_turn_count = 0andself.context_compressor._previous_summary = Nonetoreset_session_state()tests/test_session_reset_fix.py: 4 new tests verifying both fields are clearedTest plan
Fixes #2635