Skip to content

test(ci): stabilize provider and Discord fixtures#26312

Closed
smwbev wants to merge 1 commit into
NousResearch:mainfrom
smwbev:fix/ci-baseline-test-fixtures
Closed

test(ci): stabilize provider and Discord fixtures#26312
smwbev wants to merge 1 commit into
NousResearch:mainfrom
smwbev:fix/ci-baseline-test-fixtures

Conversation

@smwbev

@smwbev smwbev commented May 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • give provider-parity test agents an explicit long-context model so Nous Portal init does not fail the 64K guard before assertions run
  • make the e2e Discord mock expose discord.Forbidden as an exception class, matching discord.py and allowing the existing generic history-fetch fallback to run

Verification

  • python -m pytest tests/run_agent/test_provider_parity.py::TestDeveloperRoleSwap::test_developer_role_via_nous_portal tests/run_agent/test_provider_parity.py::TestBuildApiKwargsNousPortal::test_includes_nous_product_tags tests/run_agent/test_provider_parity.py::TestBuildApiKwargsNousPortal::test_uses_chat_completions_format tests/e2e/test_discord_adapter.py::TestMentionStrippedCommandDispatch::test_mention_then_command tests/e2e/test_discord_adapter.py::TestMentionStrippedCommandDispatch::test_nickname_mention_then_command tests/e2e/test_discord_adapter.py::TestMentionStrippedCommandDispatch::test_text_before_command_not_detected tests/e2e/test_discord_adapter.py::TestAutoThreadingPreservesCommand::test_command_detected_after_auto_thread -q -o addopts=
  • python -m pytest tests/run_agent/test_provider_parity.py tests/e2e/test_discord_adapter.py -q -o addopts=

@alt-glitch alt-glitch added type/test Test coverage or test infrastructure comp/gateway Gateway runner, session dispatch, delivery platform/discord Discord bot adapter P3 Low — cosmetic, nice to have labels May 15, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competing with #26310 — both stabilize the same Discord e2e and Nous Portal provider-parity test fixtures. #26310 also touches gateway/platforms/discord.py (runtime skip for missing .history), while this PR is test-only.

NishantEC

This comment was marked as outdated.

@teknium1

Copy link
Copy Markdown
Contributor

Automated hermes-sweeper review: this PR's test-fixture fixes are already present on current main.

Evidence:

  • tests/e2e/conftest.py:69 now defines discord_mod.Forbidden = type("Forbidden", (Exception,), {}), which matches the Discord mock exception-surface fix from this PR. git log -S points to commit ad7d3bc84c3bccf2f8f714941ca7375179adfe8f.
  • tests/run_agent/test_provider_parity.py:73 defaults Nous test agents to gpt-5 when no explicit model is supplied, added by e8a4c85e889b8990ef4cb5d70276b286d82afac7.
  • The specific Nous Portal tests now pass model="gpt-5" directly at tests/run_agent/test_provider_parity.py:351 and tests/run_agent/test_provider_parity.py:411, added by 1a82b7a1ff00a389bd39f92f8203793492fd9e5f.
  • The maintainer note on this PR correctly called out overlap with test(ci): stabilize Discord e2e and Nous Portal parity tests #26310; the current main branch now has the relevant test-fixture stabilizations.

Thanks for the focused CI stabilization work here.

@teknium1 teknium1 closed this Jun 12, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have platform/discord Discord bot adapter sweeper:implemented-on-main Sweeper: behavior already present on current main type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants