Skip to content

test(ci): stabilize Discord e2e and Nous Portal parity tests#26310

Open
aqilaziz wants to merge 2 commits into
NousResearch:mainfrom
aqilaziz:fix-nous-portal-provider-parity-tests
Open

test(ci): stabilize Discord e2e and Nous Portal parity tests#26310
aqilaziz wants to merge 2 commits into
NousResearch:mainfrom
aqilaziz:fix-nous-portal-provider-parity-tests

Conversation

@aqilaziz

@aqilaziz aqilaziz commented May 15, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • pass an explicit GPT-5 model into Nous Portal provider parity tests so they do not initialize AIAgent with an empty/default model
  • skip Discord history backfill when a channel-like object does not expose history, matching the regression covered by fix(discord): skip history backfill when channel lacks .history #26301
  • add a small regression test for the missing-history Discord path

Tests:

  • python -m pytest -o addopts= tests\run_agent\test_provider_parity.py::TestDeveloperRoleSwap::test_developer_role_via_nous_portal tests\run_agent\test_provider_parity.py::TestBuildApiKwargsNousPortal::test_includes_nous_product_tags tests\run_agent\test_provider_parity.py::TestBuildApiKwargsNousPortal::test_uses_chat_completions_format -q --tb=short
  • python -m pytest -o addopts= tests\gateway\test_discord_free_response.py::test_fetch_channel_context_returns_empty_when_channel_lacks_history -q --tb=short
  • python -m pytest -o addopts= tests\e2e\test_discord_adapter.py -q --tb=short
  • python -m ruff check gateway\platforms\discord.py tests\gateway\test_discord_free_response.py tests\run_agent\test_provider_parity.py
  • git diff --check

@aqilaziz aqilaziz changed the title test(agent): set model in Nous Portal parity tests test(ci): stabilize Discord e2e and Nous Portal parity tests May 15, 2026
@alt-glitch alt-glitch added type/test Test coverage or test infrastructure comp/gateway Gateway runner, session dispatch, delivery platform/discord Discord bot adapter P3 Low — cosmetic, nice to have labels May 15, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Competing with #26312 — both stabilize the same Discord e2e and Nous Portal provider-parity test fixtures.

NishantEC

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have platform/discord Discord bot adapter type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants