feat(providers): add first-class xAI (Grok) OAuth provider with Grok CLI auto-import#25968
Closed
am423 wants to merge 2 commits into
Closed
feat(providers): add first-class xAI (Grok) OAuth provider with Grok CLI auto-import#25968am423 wants to merge 2 commits into
am423 wants to merge 2 commits into
Conversation
Collaborator
|
현재 체크가 없고 |
Contributor
Author
|
[image: image.png]
…On Thu, May 14, 2026 at 5:52 PM badpixel ***@***.***> wrote:
*badpixel* left a comment (NousResearch/hermes-agent#25968)
<#25968 (comment)>
현재 체크가 없고 BLOCKED 상태입니다. CI/권한 상태를 확인한 뒤 다시 봐야 합니다.
—
Reply to this email directly, view it on GitHub
<#25968 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOO7CIXOT5ZEAH2CU7LRTWD42ZEZ5AVCNFSM6AAAAACY6T3TM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DINJVGM3TAOBXG4>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
Author
|
focused on the CLI delegation as it is simpler with web fallback
…On Thu, May 14, 2026 at 5:03 PM Siddharth Balyan ***@***.***> wrote:
*alt-glitch* left a comment (NousResearch/hermes-agent#25968)
<#25968 (comment)>
Related to #25941
<#25941> — both add xAI
OAuth provider support. This PR bundles ACP registry refactoring with the
xAI OAuth feature; #25941
<#25941> focuses on xAI
Coding Plan OAuth via grok CLI delegation. Maintainers should decide which
approach to merge or whether to consolidate.
—
Reply to this email directly, view it on GitHub
<#25968 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOO7CIUAAVAU2RKMLQGW7YT42Y7CZAVCNFSM6AAAAACY6T3TM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DINJVGA4TKMRZGY>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This was referenced May 15, 2026
|
Superseded by PR #27144 (Mind-Dragon:feat/xai-oauth-pr) — rebased on latest main with additional credential-sourcing improvements. |
|
Superseded by #27144 — rebased on latest main with credential-sourcing improvements merged in. |
Contributor
|
Closing as redundant — |
Contributor
Author
|
On Mon, May 18, 2026, 10:00 PM Teknium ***@***.***> wrote:
*teknium1* left a comment (NousResearch/hermes-agent#25968)
<#25968?email_source=notifications&email_token=AOO7CIRI55LBJMKB2POCMDT43PE43A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINBYGQYDGMZRGY32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4484033167>
Closing as redundant — xai-oauth is already a first-class provider on main:
70 references in hermes_cli/auth.py, registered in hermes_cli/models.py
(curated models, ProviderEntry, aliases) and
hermes_cli/runtime_provider.py (api_mode=codex_responses). The diff also
sprawls into ACP adapter, registry manifests, and an npm package — clearly
a stale fork. Thanks for the contribution; the feature you set out to add
already shipped through other paths.
—
Reply to this email directly, view it on GitHub
<#25968?email_source=notifications&email_token=AOO7CIRI55LBJMKB2POCMDT43PE43A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINBYGQYDGMZRGY32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2LK4DSL5RW63LNMVXHIX3POBSW4X3DNRUWG2Y#issuecomment-4484033167>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOO7CIUXYORQINM2QNMGYJL43PE43AVCNFSM6AAAAACY6T3TM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIOBUGAZTGMJWG4>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
xai-oauthas a first-class model provider for xAI Grok in Hermes Agent.Key Features
plugins/model-providers/xai-oauth/plugin (auth_type="oauth_external",api_mode="codex_responses")~/.grok/auth.json) — the recommended pathhermes model, runtime resolution, and status checksWhy?
xAI was previously only available via raw
XAI_API_KEY. This gives users who already use the official Grok CLI / Grok Build a seamless, first-class experience inside Hermes (matching the quality ofqwen-oauth,google-gemini-cli, andminimax-oauth).How to Test
Recommended path (Grok CLI import):
grok loginhermes modelHermes should automatically detect and import your credentials, then let you pick a Grok model.
Browser login is still available as a fallback (with a note about possible redirect URI limitations on xAI’s public desktop client).
Checklist
Contributing.md Style Summary
This is a focused feature addition that follows the established patterns in the repository. It adds a new inference provider with proper plugin structure, core CLI/auth/runtime integration, documentation, and tests. The implementation prioritizes real-world usability by making the official Grok CLI login the primary authentication method, while still supporting direct browser OAuth as a fallback.