fix(cli): handle NoConsoleScreenBufferError in _cprint on Windows#25556
Closed
ygd58 wants to merge 1 commit into
Closed
fix(cli): handle NoConsoleScreenBufferError in _cprint on Windows#25556ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
When Hermes runs in a non-interactive Windows context (Kanban task runner, Scheduled Task, subprocess without attached console), prompt_ toolkit raises NoConsoleScreenBufferError because there is no Win32 console buffer. This crashed the agent before any work was done. Fix: catch the error in _cprint and fall back to plain print() so output is not lost and execution continues normally. Fixes NousResearch#25535
Collaborator
Contributor
|
Closing as already fixed on Triage notes (high confidence): If you still see this on the latest version, please reopen with reproduction steps. (Bulk-closed during a CLI triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Kanban task runner on Windows crashes with
NoConsoleScreenBufferErrorbecause prompt_toolkit tries to access a Win32 console buffer that does not exist in non-interactive contexts. Gateway log showscrashed=1for the kanban dispatcher.Fix
Catch
NoConsoleScreenBufferErrorin_cprintand fall back toprint()so output is not lost and execution continues.Fixes #25535