Skip to content

feat(agent): Added gemma 4 to reasoning allowlist#25293

Closed
matthewlai wants to merge 1 commit into
NousResearch:mainfrom
matthewlai:feat/gemma4_reasoning
Closed

feat(agent): Added gemma 4 to reasoning allowlist#25293
matthewlai wants to merge 1 commit into
NousResearch:mainfrom
matthewlai:feat/gemma4_reasoning

Conversation

@matthewlai

Copy link
Copy Markdown
Contributor

Tested locally and seems to work well.

What does this PR do?

Added Gemma 4 to reasoning allowlist.

Related Issue

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • [v] ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

run_agent.py

Added "google/gemma-4" prefix to reasoning_model_prefixes.

How to Test

  1. Set "/reasoning show"
  2. Sent a message
  3. Got a reply with a Reasoning block.

Checklist

Code

  • [v] I've read the Contributing Guide
  • [v] My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • [v] I searched for existing PRs to make sure this isn't a duplicate
  • [v] My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • [v] I've tested on my platform:

Documentation & Housekeeping

  • [N/A] I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • [N/A] I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • [N/A] I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • [v] I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • [N/A] I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

image

@alt-glitch alt-glitch added type/feature New feature or request comp/agent Core agent loop, run_agent.py, prompt builder provider/gemini Google Gemini (AI Studio, Cloud Code) P3 Low — cosmetic, nice to have labels May 14, 2026
teknium1 added a commit that referenced this pull request May 17, 2026
@teknium1

Copy link
Copy Markdown
Contributor

Merged via PR #27247 — your commit was cherry-picked onto current main as part of a batch salvage of low-risk new-contributor PRs. Authorship preserved (feat(agent): Added gemma 4 to reasoning allowlist). Thanks for the contribution — appreciate it.

@teknium1 teknium1 closed this May 17, 2026
gweeteve pushed a commit to gweeteve/hermes-agent that referenced this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent loop, run_agent.py, prompt builder P3 Low — cosmetic, nice to have provider/gemini Google Gemini (AI Studio, Cloud Code) type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants