Skip to content

fix: resolve MiniMax OAuth auxiliary clients#25287

Closed
XXBinaryRogueXX wants to merge 2 commits into
NousResearch:mainfrom
XXBinaryRogueXX:fix/minimax-oauth-compressor-fallback
Closed

fix: resolve MiniMax OAuth auxiliary clients#25287
XXBinaryRogueXX wants to merge 2 commits into
NousResearch:mainfrom
XXBinaryRogueXX:fix/minimax-oauth-compressor-fallback

Conversation

@XXBinaryRogueXX

@XXBinaryRogueXX XXBinaryRogueXX commented May 13, 2026

Copy link
Copy Markdown

Summary

  • Resolve MiniMax OAuth auxiliary-client handling so OAuth runtime credentials are resolved before building the auxiliary Anthropic-compatible client.
  • Add/adjust targeted regression coverage for MiniMax OAuth auth status and auxiliary resolution.

Test plan

  • Targeted Hermes tests for MiniMax OAuth auth status / auxiliary provider resolution.
  • Live resolver smoke check confirmed the MiniMax OAuth auxiliary client resolves without the prior unhandled auth_type oauth_minimax path.

Notes

Prepared from Binary Rogue fork branch after live gateway issue investigation.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/agent Core agent loop, run_agent.py, prompt builder provider/minimax MiniMax (Anthropic transport) labels May 13, 2026
@alt-glitch

alt-glitch commented May 13, 2026

Copy link
Copy Markdown
Collaborator

Duplicate of #22213 (and #23639). All three PRs add oauth_minimax handling to resolve_provider_client() in auxiliary_client.py for the same root issue #21521. Note: this PR also bundles a separate context_length fallback fix in run_agent.py that is independent and not covered by #22213 — consider extracting that into its own PR.

@XXBinaryRogueXX

XXBinaryRogueXX commented May 13, 2026

Copy link
Copy Markdown
Author

Local verification from fork branch fix/minimax-oauth-compressor-fallback:

PYTHONPATH=/tmp/hermes-pr-25287 python -m pytest tests/agent/test_minimax_provider.py tests/run_agent/test_compressor_fallback_update.py -o 'addopts=' -q
48 passed in 3.75s

PR is mergeable and maintainer edits are enabled. I attempted to merge after authorizing PR scope, but this account does not have upstream MergePullRequest permission on NousResearch/hermes-agent, so this is ready for maintainer review/merge.

@alt-glitch alt-glitch mentioned this pull request May 17, 2026
Closed
2 tasks
@XXBinaryRogueXX XXBinaryRogueXX closed this by deleting the head repository May 20, 2026
This was referenced May 21, 2026
Closed
Closed
This was referenced May 30, 2026
Closed
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/agent Core agent loop, run_agent.py, prompt builder P3 Low — cosmetic, nice to have provider/minimax MiniMax (Anthropic transport) type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@XXBinaryRogueXX @alt-glitch