Skip to content

fix(auxiliary): support minimax oauth providers#23639

Open
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:codex/21521-minimax-oauth-aux
Open

fix(auxiliary): support minimax oauth providers#23639
LeonSGP43 wants to merge 1 commit into
NousResearch:mainfrom
LeonSGP43:codex/21521-minimax-oauth-aux

Conversation

@LeonSGP43

Copy link
Copy Markdown
Contributor

What does this PR do?

Supports MiniMax auxiliary providers that authenticate with oauth_minimax by resolving runtime OAuth credentials instead of treating them as unsupported non-API-key providers.

Related Issue

Fixes #21521

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 🔒 Security fix
  • 📝 Documentation update
  • ✅ Tests (adding or improving test coverage)
  • ♻️ Refactor (no behavior change)
  • 🎯 New skill (bundled or hub)

Changes Made

  • update agent/auxiliary_client.py so resolve_provider_client() accepts oauth_minimax
  • resolve MiniMax OAuth credentials via resolve_minimax_oauth_runtime_credentials() instead of the generic API-key helper
  • add a regression test in tests/agent/test_auxiliary_client.py covering the MiniMax OAuth path

How to Test

  1. uv run --frozen --extra dev pytest -q -o addopts='' tests/agent/test_auxiliary_client.py -k minimax_oauth
  2. uv run --frozen ruff check agent/auxiliary_client.py tests/agent/test_auxiliary_client.py
  3. confirm resolve_provider_client("minimax-oauth") builds the OpenAI-compatible client with the OAuth-derived token and base URL

Checklist

Code

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(scope):, feat(scope):, etc.)
  • I searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix/feature (no unrelated commits)
  • I've run pytest tests/ -q and all tests pass
  • I've added tests for my changes (required for bug fixes, strongly encouraged for features)
  • I've tested on my platform: macOS 15.5

Documentation & Housekeeping

  • I've updated relevant documentation (README, docs/, docstrings) — or N/A
  • I've updated cli-config.yaml.example if I added/changed config keys — or N/A
  • I've updated CONTRIBUTING.md or AGENTS.md if I changed architecture or workflows — or N/A
  • I've considered cross-platform impact (Windows, macOS) per the compatibility guide — or N/A
  • I've updated tool descriptions/schemas if I changed tool behavior — or N/A

Screenshots / Logs

  • targeted pytest: 1 passed, 154 deselected
  • ruff check passed

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/agent Core agent loop, run_agent.py, prompt builder provider/minimax MiniMax (Anthropic transport) duplicate This issue or pull request already exists labels May 11, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #22213 — same oauth_minimax handling in resolve_provider_client(). Both fix #21521.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent loop, run_agent.py, prompt builder duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have provider/minimax MiniMax (Anthropic transport) type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] unhandled auth_type oauth_minimax warning on auxiliary providers

2 participants