fix: add Xiaomi MiMo to reasoning_content echo-back check#25101
Closed
kennethlaw325 wants to merge 1 commit into
Closed
fix: add Xiaomi MiMo to reasoning_content echo-back check#25101kennethlaw325 wants to merge 1 commit into
kennethlaw325 wants to merge 1 commit into
Conversation
Xiaomi MiMo thinking mode requires reasoning_content on every assistant message when replaying conversation history. Without it, the API returns HTTP 400: 'The reasoning_content in the thinking mode must be passed back to the API.' Add _needs_xiaomi_tool_reasoning() method and include it in _needs_thinking_reasoning_pad() alongside DeepSeek and Kimi checks. Refs: NousResearch#15250, NousResearch#17400
Collaborator
This was referenced May 14, 2026
Contributor
|
This appears to be implemented on current main, so I’m closing this as covered by the merged Xiaomi MiMo reasoning_content echo-back fix. Evidence from this automated hermes-sweeper review:
Thanks for the report and patch; the maintainer note about the duplicate Xiaomi MiMo PRs was also taken into account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Xiaomi MiMo thinking mode requires
reasoning_contenton every assistant message when replaying conversation history. Without it, the API returns HTTP 400:This is the same requirement as DeepSeek V4 thinking (#15250) and Kimi/Moonshot thinking (#17400), but Xiaomi MiMo was not included in the
_needs_thinking_reasoning_pad()check.Changes
_needs_xiaomi_tool_reasoning()method that checks forprovider == "xiaomi"orxiaomimimo.combase URL_needs_thinking_reasoning_pad()alongside DeepSeek and KimiTest Plan
Reproduction
mimo-v2.5-pro) as the provider