fix: add Xiaomi MiMo to thinking-mode reasoning_content echo-back providers#25062
Closed
GMYXDS wants to merge 1 commit into
Closed
fix: add Xiaomi MiMo to thinking-mode reasoning_content echo-back providers#25062GMYXDS wants to merge 1 commit into
GMYXDS wants to merge 1 commit into
Conversation
Added a new method to check for Xiaomi MiMo thinking mode and updated the reasoning checks.
Collaborator
This was referenced May 13, 2026
Contributor
|
Thanks for the Xiaomi MiMo reasoning_content fix. An automated hermes-sweeper review found this is already implemented on current main via an equivalent salvaged fix, so this duplicate PR can be closed. Evidence:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new method to check for Xiaomi MiMo thinking mode and updated the reasoning checks.
What does this PR do?
When Hermes falls back from a non-thinking provider (e.g. Vertex Gemini) to Xiaomi MiMo in thinking mode, all subsequent API calls to MiMo fail with HTTP 400:
The conversation is permanently broken until
/reset._needs_thinking_reasoning_pad()only recognizes DeepSeek and Kimi/Moonshot as providers that enforcereasoning_contentecho-back. Xiaomi MiMo (mimo-v2.5-proin thinking mode) has the same requirement but is not listed. This PR adds MiMo detection to fix the issue.Related Issue
Fixes # (no issue created yet)
Type of Change
Changes Made
run_agent.py: Added_needs_mimo_tool_reasoning()method to detect Xiaomi MiMo thinking mode providers (by provider name, model name, andxiaomimimo.combase URL)run_agent.py: Updated_needs_thinking_reasoning_pad()to include_needs_mimo_tool_reasoning()in its checkHow to Test
mimo-v2.5-provia custom provider withxiaomimimo.combase URL)Reproduction (before fix)
mimo-v2.5-pro)HTTP 400: "The reasoning_content in the thinking mode must be passed back to the API."/resetAfter fix
Same steps as above — step 4 succeeds, conversation continues normally.
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass