fix: pad Xiaomi MiMo reasoning_content replay#24726
Closed
akaDRJ wants to merge 1 commit into
Closed
Conversation
111dd4c to
a650a98
Compare
Collaborator
This was referenced May 13, 2026
Author
|
Thanks for the duplicate triage. I agree #24465 should be the canonical PR since it is the earliest open fix and already covers the broader Xiaomi MiMo reasoning-content path. I posted the only extra live datapoint I found on #24465: a gateway fallback request to Closing this PR to avoid another competing fix for #24443. |
4 tasks
Author
|
Closing in favor of #24465. |
Peek-A-Booo
added a commit
to Peek-A-Booo/hermes-agent
that referenced
this pull request
May 13, 2026
… thinking blocks When strict thinking-replay providers (MiMo, Kimi, DeepSeek) replay assistant turns that are already in Anthropic content-block format with tool_use blocks but NO thinking blocks at all, inject a single-space placeholder thinking block so the upstream API does not reject with HTTP 400. This covers akaDRJ's live repro (NousResearch#24726): 29 assistant tool-use turns in Anthropic content-block form, zero with thinking/reasoning data, from a provider failover to MiMo's /anthropic endpoint. Also: address NilsR0711 review feedback: - Add defence-in-depth '/mimo-' substring check for deep-namespaced models - Add negative regression tests (MiniMax, Mistral, Phi-4, mimowave, etc.) - Add deep namespace tests (vendor/sub/mimo-v3) - Test Anthropic tool_use without thinking (new) + non-MiMo negative guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests