fix(api-server): harden jobs API — input limits, field whitelist, startup check, tests#2456
Merged
Conversation
…rtup check, tests Five improvements to the /api/jobs endpoints: 1. Startup availability check — cron module imported once at class load, endpoints return 501 if unavailable (not 500 per-request import error) 2. Input limits — name ≤ 200 chars, prompt ≤ 5000 chars, repeat must be positive int 3. Update field whitelist — only name/schedule/prompt/deliver/skills/ repeat/enabled pass through to cron.jobs.update_job, preventing arbitrary key injection 4. Deduplicated validation — _check_job_id and _check_jobs_available helpers replace repeated boilerplate 5. 32 new tests covering all endpoints, validation, auth, and cron-unavailable cases
Closed
8 tasks
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…rtup check, tests (NousResearch#2456) fix(api-server): harden jobs API — input limits, field whitelist, startup check, tests
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…rtup check, tests (NousResearch#2456) fix(api-server): harden jobs API — input limits, field whitelist, startup check, tests
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…rtup check, tests (NousResearch#2456) fix(api-server): harden jobs API — input limits, field whitelist, startup check, tests
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…rtup check, tests (NousResearch#2456) fix(api-server): harden jobs API — input limits, field whitelist, startup check, tests
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…rtup check, tests (NousResearch#2456) fix(api-server): harden jobs API — input limits, field whitelist, startup check, tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2450 (jobs API endpoints). Five hardening improvements:
name/schedule/prompt/deliver/skills/repeat/enabledpass through toupdate_job(), preventing arbitrary key injection via raw body merge_check_job_id()and_check_jobs_available()helpers replace boilerplate114 total API server tests pass (72 existing + 32 new + 10 webhook).