fix(honcho): auto-enable when API key is present#243
Merged
Conversation
Fixes NousResearch#241 When users set HONCHO_API_KEY via `hermes config set` or environment variable, they expect the integration to activate. Previously, the `enabled` flag defaulted to `false` when reading from global config, requiring users to also explicitly enable Honcho. This change auto-enables Honcho when: - An API key is present (from config file or env var) - AND `enabled` is not explicitly set to `false` in the config Users who want to disable Honcho while keeping the API key can still set `enabled: false` in their config. Also adds unit tests for the auto-enable behavior.
Contributor
|
Merged — clean fix with great test coverage. Thanks! |
13 tasks
teknium1
added a commit
that referenced
this pull request
Mar 13, 2026
…e integration, setup CLI Authored by erosika. Builds on #38 and #243. Adds async write support, configurable memory modes, context prefetch pipeline, 4 new Honcho tools (honcho_context, honcho_profile, honcho_search, honcho_conclude), full 'hermes honcho' CLI, session strategies, AI peer identity, recallMode A/B, gateway lifecycle management, and comprehensive docs. Cherry-picks fixes from PRs #831/#832 (adavyas). Co-authored-by: erosika <erosika@users.noreply.github.com> Co-authored-by: adavyas <adavyas@users.noreply.github.com>
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…resent Authored by Bartok9. Fixes NousResearch#241.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…session title integration, setup CLI Authored by erosika. Builds on NousResearch#38 and NousResearch#243. Adds async write support, configurable memory modes, context prefetch pipeline, 4 new Honcho tools (honcho_context, honcho_profile, honcho_search, honcho_conclude), full 'hermes honcho' CLI, session strategies, AI peer identity, recallMode A/B, gateway lifecycle management, and comprehensive docs. Cherry-picks fixes from PRs NousResearch#831/NousResearch#832 (adavyas). Co-authored-by: erosika <erosika@users.noreply.github.com> Co-authored-by: adavyas <adavyas@users.noreply.github.com>
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…session title integration, setup CLI Authored by erosika. Builds on NousResearch#38 and NousResearch#243. Adds async write support, configurable memory modes, context prefetch pipeline, 4 new Honcho tools (honcho_context, honcho_profile, honcho_search, honcho_conclude), full 'hermes honcho' CLI, session strategies, AI peer identity, recallMode A/B, gateway lifecycle management, and comprehensive docs. Cherry-picks fixes from PRs NousResearch#831/NousResearch#832 (adavyas). Co-authored-by: erosika <erosika@users.noreply.github.com> Co-authored-by: adavyas <adavyas@users.noreply.github.com>
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…resent Authored by Bartok9. Fixes NousResearch#241.
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…session title integration, setup CLI Authored by erosika. Builds on NousResearch#38 and NousResearch#243. Adds async write support, configurable memory modes, context prefetch pipeline, 4 new Honcho tools (honcho_context, honcho_profile, honcho_search, honcho_conclude), full 'hermes honcho' CLI, session strategies, AI peer identity, recallMode A/B, gateway lifecycle management, and comprehensive docs. Cherry-picks fixes from PRs NousResearch#831/NousResearch#832 (adavyas). Co-authored-by: erosika <erosika@users.noreply.github.com> Co-authored-by: adavyas <adavyas@users.noreply.github.com>
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…resent Authored by Bartok9. Fixes NousResearch#241.
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…session title integration, setup CLI Authored by erosika. Builds on NousResearch#38 and NousResearch#243. Adds async write support, configurable memory modes, context prefetch pipeline, 4 new Honcho tools (honcho_context, honcho_profile, honcho_search, honcho_conclude), full 'hermes honcho' CLI, session strategies, AI peer identity, recallMode A/B, gateway lifecycle management, and comprehensive docs. Cherry-picks fixes from PRs NousResearch#831/NousResearch#832 (adavyas). Co-authored-by: erosika <erosika@users.noreply.github.com> Co-authored-by: adavyas <adavyas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #241 — Honcho integration appears inactive after API key setup.
The Problem
When users run
hermes config set HONCHO_API_KEY <key>, they expect Honcho to activate. However:enabledflag inHonchoClientConfig.from_global_config()defaulted toFalseThe Fix
Auto-enable Honcho when:
enabledis not explicitly set tofalsein the configThis matches user expectations: setting an API key should activate the feature.
Users who want to disable Honcho while keeping the API key can still set
enabled: falsein their~/.honcho/config.json.Changes
honcho_integration/client.py: Modifiedfrom_global_config()to auto-enable when API key existstests/test_honcho_client_config.py: Added unit tests for auto-enable behaviorTesting
Added 7 test cases covering:
enabled: falseenabled: truefrom_env()always enabled