fix(tui): render markdown tables in bounded columns#24074
Closed
glesperance wants to merge 1 commit into
Closed
Conversation
Contributor
|
Automated hermes-sweeper review: this looks implemented on current Evidence:
Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Markdown tables in the TUI could render as visually broken output when cells contained long titles, links, or HTML line breaks. Adjacent Ink text nodes wrapped independently, which let cells collide (for example, dates glued into paper titles), and optimistic body widths could produce right-edge truncation artifacts.
Summary
<br>with spaces.Test Plan
npm test -- --run src/__tests__/markdown.test.tsnpm run type-checknpm run buildnpm exec prettier -- --check src/components/markdown.tsx src/__tests__/markdown.test.ts src/components/messageLine.tsx src/components/streamingMarkdown.tsxgit diff --checkNote: full
npm run lintstill reports pre-existing errors outside this change; the changed files only had padding warnings before local cleanup.