… (NousResearch#22687)

/clear, /new, /reset, and /undo now ask the user to confirm before
discarding conversation state — three-option prompt routed through the
existing tools.slash_confirm primitive.

Native yes/no buttons render on Telegram, Discord, and Slack (their
adapters already implement send_slash_confirm); other platforms get a
text-fallback prompt and reply with /approve, /always, or /cancel.

The classic prompt_toolkit CLI uses the same three-option flow via the
established _prompt_text_input pattern (see _confirm_and_reload_mcp).
TUI keeps its existing modal overlay (NousResearch#12312).

Gated by new config key approvals.destructive_slash_confirm (default
true). Picking 'Always Approve' flips the gate to false so subsequent
destructive commands run silently — matches the established
mcp_reload_confirm UX.

Out of scope: /cron remove (separate domain — scheduled jobs, not
session history). Existing TUI overlay env-var (HERMES_TUI_NO_CONFIRM)
left unchanged; cosmetic unification can come later.

Closes NousResearch#4069.

…ency

Problem:
unlink_tasks() removes a parent→child dependency edge but does not trigger
recompute_ready().  A child whose last blocking parent is unlinked stays
stuck in 'todo' indefinitely — it only promotes to 'ready' on the next
dispatcher tick or a manual 'hermes kanban recompute'.  For CLI-only users
without a dispatcher, the child is permanently stuck.

Root cause:
complete_task() and unblock_task() both call recompute_ready() after their
write transaction so downstream children are evaluated immediately.
unlink_tasks() was missing this call — removing a dependency is
semantically equivalent to completing one, so the same recompute is needed.

Fix:
Capture the rowcount result before the write_txn exits, then call
recompute_ready(conn) outside the transaction when a row was actually
deleted (so the child sees the updated task_links state).

Tests:
Added test_unlink_tasks_triggers_recompute_ready in
tests/hermes_cli/test_kanban_db.py: creates parent A (done) + parent C
(running), child B with both parents (todo), unlinks C→B, asserts B is
ready immediately.  Stash-verified: FAILS without fix (child stays todo),
PASSES with fix.
62/62 tests green in tests/hermes_cli/test_kanban_db.py.

Closes NousResearch#22459.

…use (NousResearch#22681)

Plugin discovery imports every bundled platform plugin at model_tools
import time. The google_chat adapter unconditionally pulled in
google.cloud.pubsub_v1, googleapiclient, grpc, httplib2, and friends at
module top — about 33 MB RSS and 110 ms wall on every CLI invocation,
even ones that never construct a gateway adapter.

Wrap the heavy imports in _load_google_modules(): an idempotent loader
that rebinds the module-level globals (pubsub_v1, service_account,
HttpError, MediaFileUpload, …) on first call and is invoked from
GoogleChatAdapter.__init__, connect(), and check_google_chat_requirements().

The HttpError = Exception placeholder is preserved for the brief window
before the loader runs, so 'except HttpError as exc:' clauses stay
correct (Python looks up the name at try/except evaluation time, not
at function definition time).

Measured impact on a 9950X3D, 7-run medians:
  import cli:              895 → 787 ms  (-108 ms / -12%)
                           133 → 110 MB  ( -23 MB / -17%)
  import model_tools:      491 → 400 ms  ( -91 ms / -19%)
                            95 →  66 MB  ( -29 MB / -31%)
  google_chat alone:       244 → 132 ms  (-112 ms / -46%)
                            83 →  50 MB  ( -33 MB / -40%)
  hermes chat -q (cold):   177 → 145 MB  ( -32 MB / -18%)

Real-world win lands on every path that imports cli.py: hermes chat,
hermes gateway, cron jobs, batch runs, subagents. Long-lived gateway
processes save ~30 MB resident.

All 157 google_chat tests pass; full gateway suite (5050 tests) green.

…ousResearch#22684)

Plugin authors had no easy way to figure out why their plugin wasn't
loading — failures were buried in agent.log at WARNING and skip reasons
(disabled, not enabled, depth cap, exclusive) were DEBUG-only and
invisible by default.

Set HERMES_PLUGINS_DEBUG=1 to attach a stderr handler at DEBUG to the
hermes_cli.plugins logger only. Surfaces:

  - which directories were scanned + manifest counts per source
  - per manifest: resolved key, name, kind, source, on-disk path
  - skip reasons (disabled, not enabled, exclusive, depth cap, no register)
  - per load: tools/hooks/slash/CLI commands the plugin registered
  - full traceback on YAML parse failure (exc_info on the existing warning)
  - full traceback on register() exceptions, pointing at the plugin author's line

Env var off (default) → zero new stderr output, same as before.

Touches only hermes_cli/plugins.py + a doc section in the plugin-build
guide + an entry in the env-vars reference. 3 new tests lock the
attach/idempotent/no-attach behavior.

Enforce the parent-completion invariant at claim_task (the single
ready->running chokepoint) and re-gate unblock_task so blocked->ready
only fires when parents are done. Prevents child tasks from running
ahead of in-progress parents under the create-then-link race.

Also adds a stress test that races concurrent create+link against
hammered claim_task and asserts no child runs while any parent is undone.

Ref: kanban/boards/cookai/workspaces/t_a6acd07d/root-cause.md
Refs: t_8d6af9d6

…n tool description (NousResearch#22694)

The delegate_task tool description hardcoded 'default 3' / 'default 2' for
max_concurrent_children / max_spawn_depth, which misled the model on any
install that raised these limits — the schema text said 'default 3' even
when the user had set max_concurrent_children=15 / max_spawn_depth=3, so
the model would self-cap at 3 and never use the headroom.

Make the description dynamic. ToolEntry gains an optional
dynamic_schema_overrides callable; registry.get_definitions() merges its
output on top of the static schema before returning it. delegate_tool
registers a builder that reads the current delegation.* config and emits:

- 'up to N items concurrently for this user' (N = max_concurrent_children)
- 'Nested delegation IS enabled / OFF for this user (max_spawn_depth=N)'
- 'orchestrator children can themselves delegate up to M more level(s)'
- 'orchestrator_enabled=false' when the kill switch is set

The model_tools cache key already includes config.yaml mtime+size, so
edits to delegation.* in config invalidate the cached tool definitions
without an explicit hook. CLI_CONFIG staleness within a process is a
pre-existing limitation of _load_config and out of scope here.

Static description / tasks.description / role.description in
DELEGATE_TASK_SCHEMA are placeholders so module import doesn't trigger
cli.CLI_CONFIG load before the test conftest can redirect HERMES_HOME.

…latform_toolsets

When platform_toolsets[<platform>] contains both a composite (e.g.
hermes-cli) and at least one configurable opt-in (e.g. spotify), the
has_explicit_config branch in _get_platform_tools silently dropped the
composite, leaving sessions with only the configurable + plugin tools
and no native tools (terminal, file, web, browser, memory, etc.).

Mirror the else-branch's subset inference for composites that sit
alongside the configurables, but apply _DEFAULT_OFF_TOOLSETS only to the
implicit expansion so user-listed default-off toolsets (spotify,
discord) survive.

Resolve git via shutil.which with POSIX and Git-for-Windows fallbacks before clone and pull so Dashboard/API installs do not misreport Git as missing.

Add regression tests for the resolver and pull subprocess invocation.

When a Telegram user replies using the native quote feature to select
only part of a prior message, _build_message_event was injecting the
ENTIRE replied-to message into reply_to_text via
message.reply_to_message.text/caption. python-telegram-bot exposes
the user-selected substring as message.quote (TextQuote.text); we now
prefer that and fall back to the full replied-to text only when no
native quote is present.

The agent-visible "[Replying to: \"...\"]" prefix can otherwise expand
the user's narrow quote into the full prior message, causing the agent
to act on unrelated actionable-looking text the user did not select
(e.g. multi-item briefings where the user quotes one bullet but the
prefix injects every bullet). Falls back cleanly when message.quote
is absent (PTB <21 or replies that don't quote a substring).

Fixes NousResearch#22619

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

…s root

Problem:
After `hermes profile use NAME`, the gateway (started via systemd with
HERMES_HOME=/root/.hermes hardcoded) ignores the active profile and
always runs as the Default profile.  WebUI, Telegram, and all non-CLI
platforms are affected.

Root cause:
_apply_profile_override() contained an early-return guard:

    if profile_name is None and os.environ.get("HERMES_HOME"):
        return   # trust the inherited value

The intent was to let child processes inherit their parent's profile via
HERMES_HOME without redundantly re-reading active_profile.  But
systemd also sets HERMES_HOME — to the hermes root (/root/.hermes),
not a profile directory — so the guard fired and silently skipped the
active_profile check.  The user's `hermes profile use NAME` write to
~/.hermes/active_profile was never seen by the gateway process.

Fix:
Only skip the active_profile check when HERMES_HOME is already a
profile directory, identified by its immediate parent directory being
named "profiles" (e.g. ~/.hermes/profiles/coder or
/opt/data/profiles/coder).  When HERMES_HOME points to a root
directory (parent name != "profiles"), continue to read active_profile.

Tests:
- test_hermes_home_at_root_with_active_profile_is_redirected: the
  bug scenario — HERMES_HOME=/root/.hermes + active_profile=coder →
  HERMES_HOME must be redirected to .../profiles/coder.
  Stash-verified: FAILS without fix, PASSES with fix.
- test_hermes_home_already_profile_dir_is_trusted: child-process
  inheritance contract unchanged — .../profiles/coder is trusted as-is.
- test_hermes_home_unset_reads_active_profile: classic path unchanged.
- test_hermes_home_unset_default_profile_no_redirect: "default" still
  produces no redirect.
4/4 tests green.

Closes NousResearch#22502.

…rror] in tests

Adds 'codex' to the _MCP_PRESETS registry so users can add it via

  Connecting to 'codex'...

  ✓ Connected! Found 2 tool(s) from 'codex':

    codex                                    Run a Codex session. Accepts configuration parameters matchi...
    codex-reply                              Continue a Codex conversation by providing the thread id and...

  Enable all 2 tools? [Y/n/select]:
  Cancelled. without manually specifying
the command and args.

Enables: codex mcp-server → Hermes native MCP client → Codex tools
available as first-class Hermes tools.

The github-pr-workflow skill wraps the URL in double-quotes
('curl -H ... "https://api.github.com/..."'), which the original
allowlist regex (\s+https://api...) did not match. Without this,
the bundled github-pr-workflow skill is still blocked at every
cron tick despite NousResearch#22605's fix landing for the bare-URL form.

Make the leading quote optional and add a regression test pinning
both single- and double-quoted forms.

The original PR placed 'pwd = pytest.importorskip("pwd")' on line 4
but 'import pytest' on line 9 — NameError on module load. Same for
test_file_sync_back.py. Plus, the in-function 'pwd = pytest.importorskip'
calls in test_auto_detected_root_is_rejected confused Python's scope
analysis (later 'import pytest' made pytest local everywhere in the
function) and caused UnboundLocalError. Drop the now-redundant
in-function importorskip calls and rely on the module-level guard.

- Restore allowed_chats gate before thread_id check so ignored_threads
  applies universally (even to guest mentions).
- Compute _message_mentions_bot once in _should_process_message to
  eliminate redundant second entity scan when guest_mode=true and the
  message does not mention the bot.
- Remove redundant _is_group_chat from _is_guest_mention (caller already
  verified the message is a group chat).
- Update _telegram_allowed_chats docstring to note guest_mode exception.
- Add test coverage: bot_command entity, text_mention entity,
  caption_entities, and ignored_threads + guest_mode interaction.
- Add nik1t7n to AUTHOR_MAP.

…rch#22764)

When session_id rotates (e.g. /new), commit_memory_session was firing
MemoryManager.on_session_end but skipping ContextEngine.on_session_end.
Engines that accumulate per-session state (LCM-style DAGs, summary
stores) leaked that state from the rotated-out session into whatever
continued under the same compressor instance.

Mirror the call shutdown_memory_provider already makes — same
lifecycle moment, same hook contract ("real session boundaries (CLI
exit, /reset, gateway expiry)"). /new is a real boundary for the old
session_id; providers keep their state but the rotated-out session_id
is done.

6 regression tests covering both-hooks-fire, no-memory-manager,
no-context-engine, both failure-tolerant paths.

Closes NousResearch#22394.

- Add SimpleNamespace, uuid imports to streaming.py
- Add contextvars import to tool_execution.py, fix duplicate logging import
- Expand agent/utils.py __all__ to 128 entries with all mixin dependencies
  (handle_function_call, _detect_tool_failure, _get_cute_tool_message_impl,
   ToolCallGuardrailController, KawaiiSpinner, etc.)

Full suite: 36 base failures -> 14 failures (all pre-existing).
3,302 passed, 0 new regressions. Fixed 22 pre-existing test failures.

…ethods (Phase 12)

Moves 531 lines of loop iteration and display logic from AIAgent into a
LoopSupportMixin class in agent/loop_support.py.

Methods extracted:
- _handle_max_iterations (215 lines) -- max iteration handling
- _interruptible_api_call (155 lines) -- interruptible API calls
- _emit_warning (34 lines) -- warning emission
- _vprint (27 lines) -- verbose printing
- _wrap_verbose (24 lines) -- verbose wrapping
- _emit_status (20 lines) -- status emission
- _should_start_quiet_spinner (19 lines) -- spinner control
- _should_emit_quiet_tool_messages (14 lines) -- quiet tool messages
- _safe_print (18 lines) -- safe printing
- _touch_activity (5 lines) -- activity tracking

Also fixes @staticmethod on _normalize_interim_visible_text and
_api_kwargs_have_image_parts, adds sys import to loop_support.py.

11 tests in test_loop_support.py (all GREEN).
run_agent.py: 10,545 -> 10,014 lines (-531).
Cumulative: 5,341 lines deleted from base (34.8% reduction).
3,327 tests pass (22 pre-existing failures, zero new regressions).

…s (Phase 13)

Moves ~593 lines of model switching and client lifecycle logic from
AIAgent into ModelSwitchMixin in agent/model_switch.py.

Methods extracted:
- switch_model (189 lines) -- runtime model switching
- _convert_to_trajectory_format (169 lines) -- trajectory conversion
- _openai_client_lock (8 lines) -- client lock context manager
- _is_openai_client_closed (30 lines) -- client state check
- _close_openai_client (24 lines) -- client teardown
- _replace_primary_openai_client (17 lines) -- client replacement
- _ensure_primary_openai_client (17 lines) -- lazy client init
- _create_request_openai_client (26 lines) -- per-request clients
- _close_request_openai_client (3 lines) -- request client cleanup
- _save_trajectory (16 lines) -- trajectory persistence

Also fixes @staticmethod on _handle_max_iterations in loop_support.py,
adds @staticmethod to _summarize_api_error, _build_keepalive_http_client,
_force_close_tcp_sockets, _api_kwargs_have_image_parts in run_agent.py.

11 tests in test_model_switch.py (all GREEN).
run_agent.py: 10,014 -> 9,520 lines (-494).
Cumulative: 5,835 lines deleted from base (38.0% reduction).
Note: _create_openai_client kept in run_agent.py to preserve monkeypatch
compatibility with existing tests that patch run_agent.OpenAI.

…s (Phase 14)

Moves 1,088 lines of API message sanitization, repair, and preparation
from AIAgent into MessagePrepMixin in agent/message_prep.py.

Methods extracted:
- _sanitize_tool_call_arguments (109) -- tool call arg cleanup
- _sanitize_api_messages (70) -- message sanitization
- _sanitize_tool_calls_for_strict_api (27) -- strict API compat
- _repair_message_sequence (100) -- message order repair
- _repair_tool_call (72) -- tool call repair
- _deduplicate_tool_calls (17) -- dedup
- _prepare_messages_for_non_vision_model (32) -- non-vision fallback
- _prepare_anthropic_messages_for_api (28) -- Anthropic prep
- _preprocess_anthropic_content (44) -- Anthropic content
- _anthropic_prompt_cache_policy (91) -- cache policy
- _anthropic_preserve_dots (34) -- Anthropic ellipsis handling
- _drop_thinking_only_and_merge_users (84) -- thinking block cleanup
- _strip_think_blocks (94) -- reasoning block removal
- _has_content_after_think_block (23) -- content check
- _copy_reasoning_content_for_api (70) -- reasoning copy
- _extract_reasoning (80) -- reasoning extraction
- _is_thinking_only_assistant (53) -- thinking check
- _drop_trailing_empty_response_scaffolding (53) -- empty cleanup

19 tests in test_message_prep.py, fix stale test_model_switch test.
run_agent.py: 9,521 -> 8,435 lines (-1,086).
Cumulative: 6,920 lines deleted from base (45.1% reduction).
Re-extracted from original source to preserve @staticmethod and nested funcs.

…(Phase 15)

Moves 420 lines of network and client management from AIAgent into
NetworkMixin in agent/network.py.

Methods extracted:
- _get_transport, _build_keepalive_http_client, _force_close_tcp_sockets
- _apply_client_headers_for_base_url, _rebuild_anthropic_client
- _try_refresh_nous/copilot/codex_client_credentials
- _credential_pool_may_recover_rate_limit, _swap_credential
- _is_azure_openai_url, _is_direct_openai_url, _is_github_copilot_url
- _is_openrouter_url, _resolved_api_call_timeout/stale_timeout_base
- _mask_api_key_for_logs, _check_openrouter_cache_status

19 tests in test_network.py (all GREEN).
run_agent.py: 8,435 -> 8,014 lines (-421).
Cumulative: 7,341 lines deleted from base (47.8% reduction).

…hase 16)

Moves 245 lines of steering, interruption, and event emission logic from
AIAgent into SteerMixin in agent/steer.py.

Methods extracted:
- steer (36), interrupt (68), clear_interrupt (33), is_interrupted (13)
- _drain_pending_steer (16), _capture_rate_limits (19)
- _fire_tool_gen_started (15), _fire_reasoning_delta (9)
- _emit_interim_assistant_message (15), _normalize_interim_visible_text (5)
- _usage_summary_for_api_request_hook (16)

12 tests in test_steer.py (all GREEN).
run_agent.py: 8,014 -> 7,769 lines (-245).
Cumulative: 7,586 lines deleted from base (49.4% reduction).

…ods (Phase 17)

Moves 304 lines of provider-specific API preparation from AIAgent into
ProviderMixin in agent/provider.py.

Methods: Qwen, DeepSeek, Kimi, LMStudio, GitHub Models, Ollama/GLM detection,
reasoning pad/tool reasoning, responses API, stop-as-truncated detection.

15 tests in test_provider.py (all GREEN).
run_agent.py: 7,769 -> 7,464 lines (-305).
Cumulative: 7,891 lines deleted from base (51.4% reduction).
Crossed 50%!

… 18)

Moves 703 lines of memory, guardrail, vision, error, and miscellaneous
helper methods from AIAgent into AuxiliaryMixin in agent/auxiliary.py.

Methods: memory write metadata, external memory sync, todo hydration,
memory shutdown, guardrail observation/halt/control, image/vision helpers,
error cleanup, API error context, token limits, session persistence,
tool call ID helpers, delegate dispatch, activity summaries.

36 tests in test_auxiliary.py (all GREEN).
run_agent.py: 7,464 -> 6,752 lines (-712).
Cumulative: 8,603 lines deleted from base (56.0% reduction).

…thods (Phase 19)

Moves 1,203 lines of API request building and lifecycle management from
AIAgent into RequestBuildMixin in agent/request_build.py.

Methods: _build_api_kwargs, _build_system_prompt, _build_assistant_message,
_format_tools_for_system_message, _dump_api_request_debug,
_spawn_background_review, _summarize_background_review_actions,
close, release_clients, _looks_like_codex_intermediate_ack,
_summarize_api_error, _get_messages_up_to_last_assistant,
_api_kwargs_have_image_parts, _invalidate_system_prompt, base_url.

16 tests in test_request_build.py (all GREEN).
run_agent.py: 6,752 -> 5,544 lines (-1,208).
Cumulative: 9,811 lines deleted from base (63.9% reduction).
Only 4 methods remain: __init__, _create_openai_client, run_conversation, chat.

…decorators, broken references

The recent mixin extraction from run_agent.py into agent/*.py left several
issues that caused runtime crashes and test failures:

- Remove stray @Property on AIAgent.__init__ (made agent uninstantiable)
- Add missing stdlib imports (os, json, re, time, copy) to 11 mixin files
  that relied on from agent.utils import * but __all__ did not export them
- Replace AIAgent.* references in message_prep.py with module-level
  equivalents (static methods cannot reference the class)
- Restore lost @staticmethod on _drop_thinking_only_and_merge_users
- Mock _read_user_config in e2e conftest to unblock /new tests
- Patch get_nous_recommended_aux_model in pool test for hermeticity

Documents the 19-phase mixin extraction refactoring with:
- Complete metrics (63.9% reduction, 495 tests, 4 methods remaining)
- Mixin breakdown with purpose for each of 14 modules
- Testing results (live E2E passes, subset 46 failures vs baseline 15)
- Commit history (19 well-labeled atomic commits)
- Lessons learned (rebase-ready, no debug prints, clean history)

Rebased cleanly onto origin/main for easy merge.