fix(gateway): skip finalize hook without prior session#23255
Open
LeonSGP43 wants to merge 1 commit into
Open
Conversation
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes #12176 with a narrow bugfix that keeps the affected path aligned with the current Hermes behavior without widening the change surface.
Related Issue
Fixes #12176
Type of Change
Changes Made
on_session_finalizewhen/resetor/newdoes not have an old session entry to finalizeHow to Test
uv run --frozen pytest -q -o addopts='' tests/gateway/test_session_boundary_hooks.py -k 'reset_without_old_session_skips_finalize_hook or reset_fires_finalize_hook or finalize_before_reset'uv run --frozen ruff check gateway/run.py tests/gateway/test_session_boundary_hooks.pyChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
Screenshots / Logs
Gateway session-boundary regression tests and Ruff checks passed locally on macOS.