fix(gateway): cron cleanup on failure + session finalize guard#12184
Open
jjjojoj wants to merge 4 commits into
Open
fix(gateway): cron cleanup on failure + session finalize guard#12184jjjojoj wants to merge 4 commits into
jjjojoj wants to merge 4 commits into
Conversation
…esearch#12175) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ousResearch#12176) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…2294) build_skills_system_prompt() loaded disabled set AFTER the cache check, so config changes to skills.disabled silently had no effect until restart. Move get_disabled_skill_names() before cache check and add sorted disabled tuple to cache key so any change invalidates the cache.
NousResearch#12064) Background task media delivery unpacked the (path, is_voice) tuple but discarded the is_voice flag, sending all audio via send_document. Now routes voice files through send_voice() when the adapter supports it.
This was referenced May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small bug fixes for the gateway runner:
#12175 — Cron ticker leaks on failure shutdown
start_gateway()returned early onshould_exit_with_failurebefore callingcron_stop.set()/cron_thread.join(), leaking the daemon cron thread. Moved cleanup into afinallyblock so it always runs.#12176 —
/newemitson_session_finalize(session_id=None)with no prior session_handle_reset_command()always firedon_session_finalize, even whenold_entrywasNone(first session). Added a guard so the finalize hook only fires when there is an actual old session to finalize.Test plan
/newon first session does not emiton_session_finalize/newon existing session still emitson_session_finalizewith correct session_id