fix(agent): inject model identity for Alibaba Coding Plan#2314
Merged
Conversation
…und API returning wrong model name
This was referenced Mar 21, 2026
teknium1
added a commit
that referenced
this pull request
Mar 21, 2026
PR #2314 checked for provider names 'alibaba-coding-plan' and 'alibaba-coding-plan-anthropic' which don't exist in the provider registry. The provider is always 'alibaba' — the condition was dead code. Fixed to check self.provider == 'alibaba'.
teknium1
added a commit
that referenced
this pull request
Mar 21, 2026
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
PR NousResearch#2314 checked for provider names 'alibaba-coding-plan' and 'alibaba-coding-plan-anthropic' which don't exist in the provider registry. The provider is always 'alibaba' — the condition was dead code. Fixed to check self.provider == 'alibaba'.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…ch#2314) fix(agent): inject model identity for Alibaba Coding Plan
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
PR NousResearch#2314 checked for provider names 'alibaba-coding-plan' and 'alibaba-coding-plan-anthropic' which don't exist in the provider registry. The provider is always 'alibaba' — the condition was dead code. Fixed to check self.provider == 'alibaba'.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…rovider check (salvage NousResearch#1748 + fix NousResearch#2314) fix: Alibaba/DashScope: preserve model dots, fix 401 auth, fix dead provider check (salvage NousResearch#1748 + fix NousResearch#2314)
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…ch#2314) fix(agent): inject model identity for Alibaba Coding Plan
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
PR NousResearch#2314 checked for provider names 'alibaba-coding-plan' and 'alibaba-coding-plan-anthropic' which don't exist in the provider registry. The provider is always 'alibaba' — the condition was dead code. Fixed to check self.provider == 'alibaba'.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…rovider check (salvage NousResearch#1748 + fix NousResearch#2314) fix: Alibaba/DashScope: preserve model dots, fix 401 auth, fix dead provider check (salvage NousResearch#1748 + fix NousResearch#2314)
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…ch#2314) fix(agent): inject model identity for Alibaba Coding Plan
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
PR NousResearch#2314 checked for provider names 'alibaba-coding-plan' and 'alibaba-coding-plan-anthropic' which don't exist in the provider registry. The provider is always 'alibaba' — the condition was dead code. Fixed to check self.provider == 'alibaba'.
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
…rovider check (salvage NousResearch#1748 + fix NousResearch#2314) fix: Alibaba/DashScope: preserve model dots, fix 401 auth, fix dead provider check (salvage NousResearch#1748 + fix NousResearch#2314)
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…ch#2314) fix(agent): inject model identity for Alibaba Coding Plan
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
PR NousResearch#2314 checked for provider names 'alibaba-coding-plan' and 'alibaba-coding-plan-anthropic' which don't exist in the provider registry. The provider is always 'alibaba' — the condition was dead code. Fixed to check self.provider == 'alibaba'.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
…rovider check (salvage NousResearch#1748 + fix NousResearch#2314) fix: Alibaba/DashScope: preserve model dots, fix 401 auth, fix dead provider check (salvage NousResearch#1748 + fix NousResearch#2314)
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…ch#2314) fix(agent): inject model identity for Alibaba Coding Plan
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
PR NousResearch#2314 checked for provider names 'alibaba-coding-plan' and 'alibaba-coding-plan-anthropic' which don't exist in the provider registry. The provider is always 'alibaba' — the condition was dead code. Fixed to check self.provider == 'alibaba'.
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
…rovider check (salvage NousResearch#1748 + fix NousResearch#2314) fix: Alibaba/DashScope: preserve model dots, fix 401 auth, fix dead provider check (salvage NousResearch#1748 + fix NousResearch#2314)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of PR #2304 by @ygd58. Closes #2300.
Alibaba Coding Plan API always returns
glm-4.7as the model name regardless of the requested model. This injects explicit model identity into the system prompt foralibaba-coding-planproviders only, so the agent correctly reports which model it is.1 file, +12 lines. Authorship preserved.