fix(cli): read root-level provider and base_url from config.yaml into model config#2283
Closed
ygd58 wants to merge 1 commit into
Closed
fix(cli): read root-level provider and base_url from config.yaml into model config#2283ygd58 wants to merge 1 commit into
ygd58 wants to merge 1 commit into
Conversation
1 task
3 tasks
teknium1
added a commit
that referenced
this pull request
Mar 26, 2026
… model config When users write root-level provider and base_url in config.yaml (instead of nesting under model:), these keys were never merged into defaults['model']. The CLI reads them from CLI_CONFIG['model']['provider'] so root-level keys were silently ignored, causing fallback to OpenRouter. Merge root-level provider and base_url into defaults['model'] after handling the model key, so custom/local provider configs work regardless of nesting. Cherry-picked from PR #2283 by ygd58. Fixes #2281.
Contributor
teknium1
added a commit
that referenced
this pull request
Mar 26, 2026
… model config (#3112) When users write root-level provider and base_url in config.yaml (instead of nesting under model:), these keys were never merged into defaults['model']. The CLI reads them from CLI_CONFIG['model']['provider'] so root-level keys were silently ignored, causing fallback to OpenRouter. Merge root-level provider and base_url into defaults['model'] after handling the model key, so custom/local provider configs work regardless of nesting. Cherry-picked from PR #2283 by ygd58. Fixes #2281.
outsourc-e
pushed a commit
to outsourc-e/hermes-agent
that referenced
this pull request
Mar 26, 2026
… model config (NousResearch#3112) When users write root-level provider and base_url in config.yaml (instead of nesting under model:), these keys were never merged into defaults['model']. The CLI reads them from CLI_CONFIG['model']['provider'] so root-level keys were silently ignored, causing fallback to OpenRouter. Merge root-level provider and base_url into defaults['model'] after handling the model key, so custom/local provider configs work regardless of nesting. Cherry-picked from PR NousResearch#2283 by ygd58. Fixes NousResearch#2281.
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
… model config (NousResearch#3112) When users write root-level provider and base_url in config.yaml (instead of nesting under model:), these keys were never merged into defaults['model']. The CLI reads them from CLI_CONFIG['model']['provider'] so root-level keys were silently ignored, causing fallback to OpenRouter. Merge root-level provider and base_url into defaults['model'] after handling the model key, so custom/local provider configs work regardless of nesting. Cherry-picked from PR NousResearch#2283 by ygd58. Fixes NousResearch#2281.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
… model config (NousResearch#3112) When users write root-level provider and base_url in config.yaml (instead of nesting under model:), these keys were never merged into defaults['model']. The CLI reads them from CLI_CONFIG['model']['provider'] so root-level keys were silently ignored, causing fallback to OpenRouter. Merge root-level provider and base_url into defaults['model'] after handling the model key, so custom/local provider configs work regardless of nesting. Cherry-picked from PR NousResearch#2283 by ygd58. Fixes NousResearch#2281.
olympus-terminal
pushed a commit
to olympus-terminal/hermes-agent
that referenced
this pull request
May 16, 2026
… model config (NousResearch#3112) When users write root-level provider and base_url in config.yaml (instead of nesting under model:), these keys were never merged into defaults['model']. The CLI reads them from CLI_CONFIG['model']['provider'] so root-level keys were silently ignored, causing fallback to OpenRouter. Merge root-level provider and base_url into defaults['model'] after handling the model key, so custom/local provider configs work regardless of nesting. Cherry-picked from PR NousResearch#2283 by ygd58. Fixes NousResearch#2281.
gweeteve
pushed a commit
to gweeteve/hermes-agent
that referenced
this pull request
Jun 2, 2026
… model config (NousResearch#3112) When users write root-level provider and base_url in config.yaml (instead of nesting under model:), these keys were never merged into defaults['model']. The CLI reads them from CLI_CONFIG['model']['provider'] so root-level keys were silently ignored, causing fallback to OpenRouter. Merge root-level provider and base_url into defaults['model'] after handling the model key, so custom/local provider configs work regardless of nesting. Cherry-picked from PR NousResearch#2283 by ygd58. Fixes NousResearch#2281.
Egavasyug
pushed a commit
to Egavasyug/hermes-agent
that referenced
this pull request
Jun 10, 2026
… model config (NousResearch#3112) When users write root-level provider and base_url in config.yaml (instead of nesting under model:), these keys were never merged into defaults['model']. The CLI reads them from CLI_CONFIG['model']['provider'] so root-level keys were silently ignored, causing fallback to OpenRouter. Merge root-level provider and base_url into defaults['model'] after handling the model key, so custom/local provider configs work regardless of nesting. Cherry-picked from PR NousResearch#2283 by ygd58. Fixes NousResearch#2281.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2281
Root Cause
When users write root-level
providerandbase_urlin config.yaml:model: kimi-k2.5:cloud
provider: custom
base_url: http://localhost:11434/v1
These root-level keys were never merged into
defaults["model"]inload_cli_config(). Only dict-format model configs were handled. The provider/base_url were silently ignored, causing fallback to OpenRouter.Fix
After handling the model key, also check for root-level
providerandbase_urland merge them intodefaults["model"].