fix: correct zsh completion _arguments exclusion syntax#22728
Closed
AnnasMazhar wants to merge 1 commit into
Closed
fix: correct zsh completion _arguments exclusion syntax#22728AnnasMazhar wants to merge 1 commit into
AnnasMazhar wants to merge 1 commit into
Conversation
The generated zsh completion script used invalid _arguments syntax:
'(-h --help){-h,--help}[Show help and exit]'
zsh only accepts single-letter options (or '-') inside the () mutual
exclusion group — long options like --help cause a parse error.
Fixed by:
- Removing long options from () exclusion specs
- Using (-) for help/version (no mutual exclusion needed)
- Using (-p) for --profile (single-char -p is valid)
- Keeping brace groups {-h,--help} for option aliases
Fixes NousResearch#22686
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #22686
The generated
hermes completion zshscript used invalid_argumentssyntax:'(-h --help){-h,--help}[Show help and exit]'zsh only accepts single-letter options (or
-) inside the()mutual exclusion group — long options like--helpcause a parse error.Fix
()exclusion specs(-)for help/version (no mutual exclusion needed)(-p)for--profile(-pis a single char, valid){-h,--help}for option aliasesTesting
zsh -n— zero errorsChanged file:
hermes_cli/completion.py