fix(completion): use valid zsh _arguments exclusion-group syntax#22727
Closed
Sanjays2402 wants to merge 1 commit into
Closed
fix(completion): use valid zsh _arguments exclusion-group syntax#22727Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
The generated zsh completion script used `(-h --help)` as the exclusion
group for `_arguments`, which zsh rejects with:
_arguments:comparguments: invalid argument: (-h --help){-h,--help}[...]
Exclusion groups in `_arguments` cannot contain long options. Use the
canonical `(-)` form (exclude all other options) which correctly
handles flag pairs like `-h`/`--help`.
Fixes NousResearch#22686
Contributor
This was referenced May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the invalid
(-X --Y)exclusion groups emitted in the zsh completion script with the canonical(-)form. Long options cannot appear inside_argumentsexclusion groups, and the previous output caused zsh to reject the script with_arguments:comparguments: invalid argument: (-h --help){-h,--help}[...], breaking tab completion entirely on zsh.Repro
Changes
hermes_cli/completion.py(generate_zsh): emit(-)instead of(-X --Y)so each flag pair is rendered as(-){-X,--Y}'[desc]'(e.g.(-){-h,--help}[Show help and exit]). Fixes the three top-level option specs (-h/--help,-V/--version,-p/--profile).Testing
git diffshows a 3-line minimal change in the zsh emitter.tests/hermes_cli/test_completion.py(the completion-relevant ones) all pass.expect-driven interactive zsh:_arguments:comparguments:327: invalid argument: (-h --help){-h,--help}[Show help and exit]on first TAB._argumentserrors.Fixes #22686