fix: correct zsh _arguments syntax in shell completion generation#22720
Closed
Ninso112 wants to merge 1 commit into
Closed
fix: correct zsh _arguments syntax in shell completion generation#22720Ninso112 wants to merge 1 commit into
Ninso112 wants to merge 1 commit into
Conversation
The generated zsh completion script used invalid mutual-exclusion group
syntax like '(-h --help){-h,--help}' which caused zsh to reject the
script with 'invalid argument' errors.
Replace with '(-){-h,--help}' where (-) means no mutual exclusion,
which is correct since short and long forms are aliases of the same
option. This follows zsh's official _arguments syntax guidelines.
Fixes NousResearch#22686
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_argumentssyntax in the generated shell completion script that caused zsh to reject the script withinvalid argumenterrors(-h --help)with(-)(no exclusion), which is correct since short/long forms are aliases of the same optionWhy
The hardcoded exclusion groups in
generate_zsh()contained spaces between short and long option forms (e.g.(-h --help)), which zsh's_argumentsparser rejects. The fix uses(-)to indicate no mutual exclusion, following zsh's official completion syntax guidelines.Closes #22686